New version of the bbh shootout

tools/PictureRenderer.h

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef PictureRenderer_DEFINED
 #define PictureRenderer_DEFINED
 
@@ skipping 65 matching lines @@
 #if SK_SUPPORT_GPU
         kGPU_DeviceType,
 #endif
     };
 
     enum BBoxHierarchyType {
         kNone_BBoxHierarchyType = 0,
         kQuadTree_BBoxHierarchyType,
         kRTree_BBoxHierarchyType,
         kTileGrid_BBoxHierarchyType,
+
+        kLast_BBoxHierarchyType = kTileGrid_BBoxHierarchyType,
     };
+    static const int kBBoxHierarchyTypeCount = kLast_BBoxHierarchyType + 1;

[reed1, 2014/03/07 13:39:49]

stylistically, I'm not a fan of these in public headers.

[mtklein, 2014/03/07 13:41:15]

If you can get away with it, I'd recommend using only the Count.  Having
kLast_Thing can make compilers warnings get annoying about non-exhaustive
switches.

[iancottrell, 2014/03/07 14:52:47]

Removed the count.
kLast seemed to be the standard across all of skia, I though all compilers had
been fixed for those exhaustive messages now?

 
     // this uses SkPaint::Flags as a base and adds additional flags
     enum DrawFilterFlags {
         kNone_DrawFilterFlag = 0,
         kHinting_DrawFilterFlag = 0x10000, // toggles between no hinting and normal hinting
         kSlightHinting_DrawFilterFlag = 0x20000, // toggles between slight and normal hinting
         kAAClip_DrawFilterFlag = 0x40000, // toggles between soft and hard clip
         kMaskFilter_DrawFilterFlag = 0x80000, // toggles on/off mask filters (e.g., blurs)
     };
 
@@ skipping 514 matching lines @@
 
     typedef PictureRenderer INHERITED;
 };
 
 extern PictureRenderer* CreateGatherPixelRefsRenderer();
 extern PictureRenderer* CreatePictureCloneRenderer();
 
 }
 
 #endif  // PictureRenderer_DEFINED