Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 186973004: Remove MCRec.fNext (Closed)

Created:
6 years, 9 months ago by f(malita)
Modified:
6 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove MCRec.fNext No longer used. R=reed@google.com Committed: http://code.google.com/p/skia/source/detail?r=13690

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/core/SkCanvas.cpp View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
f(malita)
Also, SkCanvas::fMCRecStorage looks way undersized: it can't even hold one MCRec on 64bit platforms (sizeof(fMCRecStorage): ...
6 years, 9 months ago (2014-03-06 19:11:16 UTC) #1
reed1
Interesting. How long has it be unused? Is this from the change in using/not-using a ...
6 years, 9 months ago (2014-03-06 19:22:35 UTC) #2
f(malita)
On 2014/03/06 19:22:35, reed1 wrote: > Interesting. How long has it be unused? Is this ...
6 years, 9 months ago (2014-03-06 19:26:53 UTC) #3
mtklein
Well that's silly. lgtm If we're already not using the static storage on 64 bit, ...
6 years, 9 months ago (2014-03-06 19:43:21 UTC) #4
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 9 months ago (2014-03-06 19:52:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/186973004/1
6 years, 9 months ago (2014-03-06 19:52:55 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 19:56:59 UTC) #7
Message was sent while issue was closed.
Change committed as 13690

Powered by Google App Engine
This is Rietveld 408576698