Issue 186973002: Add RenderThread::GetShutdownEvent().

Issue 186973002: Add RenderThread::GetShutdownEvent(). (Closed)

Created:
6 years, 9 months ago by teravest

Modified:
6 years, 9 months ago

Reviewers:
jam, Jói

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add RenderThread::GetShutdownEvent(). This change adds RenderThread::GetShutdownEvent() to the public content API. This is required for code outside of content/ that wants to safely use interfaces like SyncChannel. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255275

Patch Set 1 #

Patch Set 2 : Fix for MockRenderThread #

Patch Set 3 : Build fix #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -5 lines)			Patch
M	components/nacl/renderer/ppb_nacl_private_impl.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	content/public/renderer/render_thread.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/public/test/mock_render_thread.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/test/mock_render_thread.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Jói

I think this is OK, but looping in jam@ to see if he has other ...

6 years, 9 months ago (2014-03-05 14:13:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/186973002/40001

6 years, 9 months ago (2014-03-05 22:32:58 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/186973002/40001

6 years, 9 months ago (2014-03-06 00:06:58 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/186973002/40001

6 years, 9 months ago (2014-03-06 02:50:36 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/186973002/40001

6 years, 9 months ago (2014-03-06 03:15:04 UTC) #8

Message was sent while issue was closed.

Change committed as 255275

Expand Messages | Collapse Messages