Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 1869693004: [doc] add public docs about Webview Policies (Closed)

Created:
4 years, 8 months ago by dgn
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[doc] add public docs about Webview Policies BUG=536733 Committed: https://crrev.com/14820ae0e04c2ed84691d4980f185009d0a01d0c Cr-Commit-Position: refs/heads/master@{#386059}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A docs/webview_policies.md View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
dgn
PTAL
4 years, 8 months ago (2016-04-07 15:30:42 UTC) #2
Bernhard Bauer
Also, maybe add a link to this from chromium.org/administrators/ somewhere? Or maybe from the policy ...
4 years, 8 months ago (2016-04-07 15:55:55 UTC) #3
dgn
PTAL. I'll link it in the doc once it lands. https://codereview.chromium.org/1869693004/diff/1/docs/webview_policies.md File docs/webview_policies.md (right): https://codereview.chromium.org/1869693004/diff/1/docs/webview_policies.md#newcode17 ...
4 years, 8 months ago (2016-04-08 12:29:27 UTC) #4
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-04-08 12:30:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869693004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869693004/20001
4 years, 8 months ago (2016-04-08 12:43:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-08 13:15:54 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/14820ae0e04c2ed84691d4980f185009d0a01d0c Cr-Commit-Position: refs/heads/master@{#386059}
4 years, 8 months ago (2016-04-08 13:17:42 UTC) #10
dgn
4 years, 8 months ago (2016-04-08 13:31:59 UTC) #11
Message was sent while issue was closed.
Linked in https://sites.google.com/a/chromium.org/dev/administrators?pli=1

Powered by Google App Engine
This is Rietveld 408576698