Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1869693003: [compiler] Make feedback vector cope with flag changes. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Make feedback vector cope with flag changes. This fixes corner cases where the layout of feedback vectors baked into the snapshot is different from the expected layout, depending on some runtime flags. We make sure the feedback vector is regenereated for functions that are not compiled. Flag changes of this kind are only allowed when code is not serialized. An alternative solution would be to not serialize the feedback vector for such cases in the first place. That solution however would have a higher overhead, as it would required the serializer to be able to recognize feedback vectors while generating a snapshot. R=mvstanton@chromium.org TEST=mjsunit/regress/regress-crbug-600995 BUG=chromium:600995 LOG=n Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c Cr-Commit-Position: refs/heads/master@{#35339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M src/compiler.cc View 1 chunk +5 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-600995.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-07 13:14:44 UTC) #1
mvstanton
lgtm
4 years, 8 months ago (2016-04-07 14:42:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869693003/1
4 years, 8 months ago (2016-04-07 15:31:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 15:34:12 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c Cr-Commit-Position: refs/heads/master@{#35339}
4 years, 8 months ago (2016-04-07 15:35:08 UTC) #7
Michael Hablich
4 years, 8 months ago (2016-04-11 15:09:32 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1876103002/ by hablich@chromium.org.

The reason for reverting is: Blocks current roll:
https://codereview.chromium.org/1876713002/ according to bisect:
https://codereview.chromium.org/1872353002/#ps80001.

Powered by Google App Engine
This is Rietveld 408576698