chrome/browser/supervised_user/supervised_user_theme.cc - Issue 1869693002: Theme suppliers: Avoid all Image copying.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_theme.cc

Issue 1869693002: Theme suppliers: Avoid all Image copying. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/supervised_user/supervised_user_theme.cc

diff --git a/chrome/browser/supervised_user/supervised_user_theme.cc b/chrome/browser/supervised_user/supervised_user_theme.cc

index 22e702b3c579d942495274f0fe5fbeb773483a8b..fa008f5dd54dc7965c9de31eef456ad8c7f0fde9 100644

--- a/chrome/browser/supervised_user/supervised_user_theme.cc

+++ b/chrome/browser/supervised_user/supervised_user_theme.cc

@@ -56,9 +56,9 @@ bool SupervisedUserTheme::GetColor(int id, SkColor* color) const {

return false;

}

-gfx::Image SupervisedUserTheme::GetImageNamed(int id) {

+const gfx::Image& SupervisedUserTheme::GetImageNamed(int id) {

if (!HasCustomImage(id))

- return gfx::Image();

+ return empty_image();

id = MapToSupervisedUserResourceIds(id);

return ResourceBundle::GetSharedInstance().GetNativeImageNamed(id);