Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1869683002: S390: Extend test timeout. (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
Reviewers:
john.yan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Extend test timeout. TBR=jyan@ca.ibm.com NOTRY=true Committed: https://crrev.com/aa81cc689d62874b70cb10a85c17fde65a5f3c9c Cr-Commit-Position: refs/heads/master@{#35324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/run-tests.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Achenbach
TBR
4 years, 8 months ago (2016-04-07 08:28:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869683002/1
4 years, 8 months ago (2016-04-07 08:28:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 08:30:30 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aa81cc689d62874b70cb10a85c17fde65a5f3c9c Cr-Commit-Position: refs/heads/master@{#35324}
4 years, 8 months ago (2016-04-07 08:31:28 UTC) #9
Michael Achenbach
Hmm - that didn't work as expected. Will investigate. Another solution would be to simply ...
4 years, 8 months ago (2016-04-07 09:58:03 UTC) #10
Michael Achenbach
4 years, 8 months ago (2016-04-08 13:03:50 UTC) #11
Message was sent while issue was closed.
Now test timeouts work properly. Unfortunately, double timeout is still not
enough for 1-2 tests:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20s390%2...

I suggest to just skip those tests or at least mark them as SLOW.

Powered by Google App Engine
This is Rietveld 408576698