Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1869673002:
Update V8 to version 5.1.282.1 (cherry-pick). (Closed)
|
Created:
4 years, 8 months ago by v8-autoroll Modified:
4 years, 8 months ago CC:
chromium-reviews, Hannes Payer (out of office) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate V8 to version 5.1.282.1 (cherry-pick).
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/167dc63b..23da806c
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
Committed: https://crrev.com/844fbc8a6dfad204e481d5a4177f366b87289e3e
Cr-Commit-Position: refs/heads/master@{#385757}
Patch Set 1 #Messages
Total messages: 25 (10 generated)
The CQ bit was checked by v8-autoroll@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869673002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by v8-autoroll@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869673002/1
Hmm - the asan problem happens consistently with the v8 roll only. Also on the last roll attempt. Maybe there's another problem? The root cause is probably somewhere else in mojo, but maybe the roll uncovers it.
On 2016/04/07 09:53:59, Michael Achenbach wrote: > Hmm - the asan problem happens consistently with the v8 roll only. Also on the > last roll attempt. Maybe there's another problem? The root cause is probably > somewhere else in mojo, but maybe the roll uncovers it. Possible. Lots of GC changes in the roll. Can you start a bisect please?
Description was changed from ========== Update V8 to version 5.1.282.1 (cherry-pick). Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/167dc63b..23da806c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelhe... ========== to ========== Update V8 to version 5.1.282.1 (cherry-pick). Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/167dc63b..23da806c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelhe... ==========
On 2016/04/07 10:04:31, Hablich wrote: > On 2016/04/07 09:53:59, Michael Achenbach wrote: > > Hmm - the asan problem happens consistently with the v8 roll only. Also on the > > last roll attempt. Maybe there's another problem? The root cause is probably > > somewhere else in mojo, but maybe the roll uncovers it. > > Possible. Lots of GC changes in the roll. Can you start a bisect please? I'm far from having a working chromium checkout. I could do some pseudo bisection on the bots if that helps?
On 2016/04/07 10:17:25, Michael Achenbach wrote: > On 2016/04/07 10:04:31, Hablich wrote: > > On 2016/04/07 09:53:59, Michael Achenbach wrote: > > > Hmm - the asan problem happens consistently with the v8 roll only. Also on > the > > > last roll attempt. Maybe there's another problem? The root cause is probably > > > somewhere else in mojo, but maybe the roll uncovers it. > > > > Possible. Lots of GC changes in the roll. Can you start a bisect please? > > I'm far from having a working chromium checkout. I could do some pseudo > bisection on the bots if that helps? Please. I can narrow it down later at my workstation.
On 2016/04/07 10:19:17, Hablich wrote: > On 2016/04/07 10:17:25, Michael Achenbach wrote: > > On 2016/04/07 10:04:31, Hablich wrote: > > > On 2016/04/07 09:53:59, Michael Achenbach wrote: > > > > Hmm - the asan problem happens consistently with the v8 roll only. Also on > > the > > > > last roll attempt. Maybe there's another problem? The root cause is > probably > > > > somewhere else in mojo, but maybe the roll uncovers it. > > > > > > Possible. Lots of GC changes in the roll. Can you start a bisect please? > > > > I'm far from having a working chromium checkout. I could do some pseudo > > bisection on the bots if that helps? > > Please. I can narrow it down later at my workstation. on it
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by v8-autoroll@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869673002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by v8-autoroll@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869673002/1
Message was sent while issue was closed.
Description was changed from ========== Update V8 to version 5.1.282.1 (cherry-pick). Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/167dc63b..23da806c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelhe... ========== to ========== Update V8 to version 5.1.282.1 (cherry-pick). Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/167dc63b..23da806c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelhe... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Update V8 to version 5.1.282.1 (cherry-pick). Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/167dc63b..23da806c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelhe... ========== to ========== Update V8 to version 5.1.282.1 (cherry-pick). Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/167dc63b..23da806c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelhe... Committed: https://crrev.com/844fbc8a6dfad204e481d5a4177f366b87289e3e Cr-Commit-Position: refs/heads/master@{#385757} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/844fbc8a6dfad204e481d5a4177f366b87289e3e Cr-Commit-Position: refs/heads/master@{#385757} |
