Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1869613003: add header guard to SkPM4fPriv.h to prevent accidental multiple inclusion (Closed)

Created:
4 years, 8 months ago by lsalzman1
Modified:
4 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add header guard to SkPM4fPriv.h to prevent accidental multiple inclusion This works around some issues with Firefox's unified sources build system. BUG=skia:5173 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1869613003 Committed: https://skia.googlesource.com/skia/+/8dea4e41a11fd526fa533396173f72af0f9042d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/core/SkPM4fPriv.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
lsalzman1
Would like to get this one in before chrome/m51 tagging...
4 years, 8 months ago (2016-04-07 20:43:38 UTC) #4
reed1
lgtm
4 years, 8 months ago (2016-04-07 20:50:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869613003/1
4 years, 8 months ago (2016-04-07 20:50:16 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 21:04:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8dea4e41a11fd526fa533396173f72af0f9042d7

Powered by Google App Engine
This is Rietveld 408576698