Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 18696003: Replace a few hard-coded strings with their constant counterparts. (Closed)

Created:
7 years, 5 months ago by Raphael Kubo da Costa (rakuco)
Modified:
7 years, 5 months ago
Reviewers:
Ted C, bulach, Yaron, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Replace a few hard-coded strings with their constant counterparts. R=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/android/java/src/org/chromium/ui/SelectFileDialog.java View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Raphael Kubo da Costa (rakuco)
7 years, 5 months ago (2013-07-04 17:40:39 UTC) #1
bulach
lgtm, thanks!
7 years, 5 months ago (2013-07-05 09:08:23 UTC) #2
Raphael Kubo da Costa (rakuco)
7 years, 5 months ago (2013-07-05 10:51:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r210289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698