Remove all PWL_Note classes

Remove all PWL_Note classes

The PWL_Note clasess are never instantiated, remove them and their
implementation. PWL_Note was the only caller to enable spellcheck so this
allows us to remove IPWL_SpellCheck and the conditionals for PES_SPELLCHECK.

BUG=pdfium:468
Committed: https://pdfium.googlesource.com/pdfium/+/8da140e8747920057a2f2bbcf5c78e40bb198733

[dsinclair, 2016-04-07 13:43:09]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-04-07 13:43:10]

PTAL. I folded the IPWL_NoteHandler change into this one as I ended up removing
the entire file.

[Tom Sepez, 2016-04-07 15:31:25]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-07 15:31:26]

I've got to run shortly, adding Lei who may be able to run this to ground before
I get back on Friday.  Thanks.

https://codereview.chromium.org/1869533003/diff/1/fpdfsdk/pdfwindow/PWL_Edit.cpp
File fpdfsdk/pdfwindow/PWL_Edit.cpp (right):

https://codereview.chromium.org/1869533003/diff/1/fpdfsdk/pdfwindow/PWL_Edit....
fpdfsdk/pdfwindow/PWL_Edit.cpp:26: m_pFormFiller = NULL;
nit: move to initializer list, also nullptrs.

[dsinclair, 2016-04-07 16:25:27]

https://codereview.chromium.org/1869533003/diff/1/fpdfsdk/pdfwindow/PWL_Edit.cpp
File fpdfsdk/pdfwindow/PWL_Edit.cpp (right):

https://codereview.chromium.org/1869533003/diff/1/fpdfsdk/pdfwindow/PWL_Edit....
fpdfsdk/pdfwindow/PWL_Edit.cpp:26: m_pFormFiller = NULL;
On 2016/04/07 15:31:26, Tom Sepez wrote:
> nit: move to initializer list, also nullptrs.

Done.

[Lei Zhang, 2016-04-07 19:08:13]

lgtm

[dsinclair, 2016-04-07 19:08:35]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-04-07 19:08:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869533003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869533003/20001

[commit-bot: I haz the power, 2016-04-07 19:40:01]

Description was changed from

==========
Remove all PWL_Note classes

The PWL_Note clasess are never instantiated, remove them and their
implementation. PWL_Note was the only caller to enable spellcheck so this
allows us to remove IPWL_SpellCheck and the conditionals for PES_SPELLCHECK.

BUG=pdfium:468
==========

to

==========
Remove all PWL_Note classes

The PWL_Note clasess are never instantiated, remove them and their
implementation. PWL_Note was the only caller to enable spellcheck so this
allows us to remove IPWL_SpellCheck and the conditionals for PES_SPELLCHECK.

BUG=pdfium:468

Committed:
https://pdfium.googlesource.com/pdfium/+/8da140e8747920057a2f2bbcf5c78e40bb19...
==========

[commit-bot: I haz the power, 2016-04-07 19:40:02]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8da140e8747920057a2f2bbcf5c78e40bb19...