Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1869523003: Move LayoutTests/bluetooth/resources to LayoutTests/resources/bluetooth. (Closed)

Created:
4 years, 8 months ago by Jeffrey Yasskin
Modified:
4 years, 8 months ago
Reviewers:
scheib, ortuno
CC:
blink-reviews, chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LayoutTests/bluetooth/resources to LayoutTests/resources/bluetooth. To support HTTP bluetooth tests, where the run-webkit-tests HTTP server serves resources/ but not bluetooth/resources. Committed: https://crrev.com/72d20f60afaed51db0ef782bad11d54e3ae36ad2 Cr-Commit-Position: refs/heads/master@{#385587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -426 lines) Patch
M third_party/WebKit/LayoutTests/bluetooth/advertising-data.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristicProperties.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/connect.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/disconnect.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/detach-gc.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/gc-detach.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/hide-detach.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristic.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristic-blacklist.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blacklisted-characteristics.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blacklisted-characteristics-with-uuid.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/characteristics-found.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/characteristics-found-with-uuid.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/characteristics-not-found.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/characteristics-not-found-with-uuid.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/correct-characteristics.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/device-goes-out-of-range.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/device-goes-out-of-range-with-uuid.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/get-same-characteristics.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/invalid-characteristic-name.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/service-is-removed.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/service-is-removed-with-uuid.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/getPrimaryService.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/idl-BluetoothDevice.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/iframeRequestDevice.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/notifications.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/readValue.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/readValue-blacklist.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice-canonicalize-filter.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice-matches-a-filter.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/requestDevice-sandboxed-iframe.html View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/resources/bluetooth-helpers.js View 1 chunk +0 lines, -327 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/resources/connect-iframe.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/resources/requestDevice-in-iframe.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/resources/requestDevice-in-sandboxed-iframe.html View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/writeValue/blacklisted-characteristic.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/writeValue/characteristic-is-removed.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/writeValue/device-goes-out-of-range.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/writeValue/service-is-removed.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/writeValue/value-too-long.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/writeValue/write-fails.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/writeValue/write-succeeds.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/writeValue/write-updates-value.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/resources/bluetooth/connect-iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/resources/bluetooth/requestDevice-in-iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/resources/bluetooth/requestDevice-in-sandboxed-iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Dependent Patchsets:

Issue 1862953002 Patch 40001

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869523003/1
4 years, 8 months ago (2016-04-06 21:23:48 UTC) #2
Jeffrey Yasskin
This is needed for https://codereview.chromium.org/1862953002/. At least, I think I can't depend on bluetooth/resources from ...
4 years, 8 months ago (2016-04-06 21:29:29 UTC) #4
ortuno
lgtm
4 years, 8 months ago (2016-04-06 21:50:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869523003/1
4 years, 8 months ago (2016-04-06 21:56:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 23:53:12 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 23:54:48 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/72d20f60afaed51db0ef782bad11d54e3ae36ad2
Cr-Commit-Position: refs/heads/master@{#385587}

Powered by Google App Engine
This is Rietveld 408576698