Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/target_unittest.cc

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/functions_unittest.cc ('K') | « tools/gn/target_generator.cc ('k') | tools/gn/template.h » ('j') | tools/gn/template.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target_unittest.cc
diff --git a/tools/gn/target_unittest.cc b/tools/gn/target_unittest.cc
index b3a85b75a0d824d28bff94e24065c006a8bfb911..30bf99f62239c9abade7ba91cfa523e9e00b93c0 100644
--- a/tools/gn/target_unittest.cc
+++ b/tools/gn/target_unittest.cc
@@ -429,7 +429,7 @@ TEST(Target, LinkAndDepOutputs) {
Toolchain toolchain(setup.settings(), Label(SourceDir("//tc/"), "tc"));
- scoped_ptr<Tool> solink_tool(new Tool());
+ std::unique_ptr<Tool> solink_tool(new Tool());
solink_tool->set_output_prefix("lib");
solink_tool->set_default_output_extension(".so");
@@ -468,7 +468,7 @@ TEST(Target, RuntimeLinkOuput) {
Toolchain toolchain(setup.settings(), Label(SourceDir("//tc/"), "tc"));
- scoped_ptr<Tool> solink_tool(new Tool());
+ std::unique_ptr<Tool> solink_tool(new Tool());
solink_tool->set_output_prefix("");
solink_tool->set_default_output_extension(".dll");
« tools/gn/functions_unittest.cc ('K') | « tools/gn/target_generator.cc ('k') | tools/gn/template.h » ('j') | tools/gn/template.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698