[heap] Do not perform black allocation in memory reducing mode.

[heap] Do not perform black allocation in memory reducing mode.

Black allocation discards all old-space free-lists, which may be quite full when we perform memory reducing GCs.

BUG=chromium:599174
LOG=n

Committed: https://crrev.com/a81c47f35886d88d646d0cf0f4892271a9288389
Cr-Commit-Position: refs/heads/master@{#35374}

[Hannes Payer (out of office), 2016-04-06 16:14:05]

Description was changed from

==========
[heap] Do not perform black allocation in memory reducing mode.

BUG=chromium:599174
LOG=n
==========

to

==========
[heap] Do not perform black allocation in memory reducing mode.

Black allocation discards all old-space free-lists, which may be quite full when
we perform memory reducing GCs.

BUG=chromium:599174
LOG=n
==========

[Hannes Payer (out of office), 2016-04-06 16:14:13]

hpayer@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2016-04-06 16:55:05]

Not sure about this one. Invariant that black allocation is on at the end of
incremental GC (to process weak references incrementally) would be great.
Without such invariant the complexity of the last phases of GC increases because
they would have to handle both cases (black allocation on / off).

Maybe better approach would be to adjust GC schedule, so that it is more
aggressive?

Let's discuss it offline.

[Hannes Payer (out of office), 2016-04-07 14:58:48]

As discussed offline, I start black allocation when we finalize incremental
marking if it was not started earlier.

[ulan, 2016-04-07 15:26:30]

lgtm

[Hannes Payer (out of office), 2016-04-07 16:58:49]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2016-04-07 16:58:50]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/1869493002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-07 16:58:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869493002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869493002/60001

[commit-bot: I haz the power, 2016-04-07 17:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 17:13:06]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/16373)

[Hannes Payer (out of office), 2016-04-08 11:43:25]

https://codereview.chromium.org/1869493002/diff/80001/src/heap/incremental-ma...
File src/heap/incremental-marking.cc (right):

https://codereview.chromium.org/1869493002/diff/80001/src/heap/incremental-ma...
src/heap/incremental-marking.cc:586: if (black_allocation_) {
We cannot guarantee that black allocation was on. An explicit GC call after
starting marking may result in a full GC where nothing was allocated black.

[Hannes Payer (out of office), 2016-04-11 08:58:43]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2016-04-11 08:58:43]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/1869493002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-04-11 08:58:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869493002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869493002/80001

[commit-bot: I haz the power, 2016-04-11 09:21:36]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-11 09:23:24]

Description was changed from

==========
[heap] Do not perform black allocation in memory reducing mode.

Black allocation discards all old-space free-lists, which may be quite full when
we perform memory reducing GCs.

BUG=chromium:599174
LOG=n
==========

to

==========
[heap] Do not perform black allocation in memory reducing mode.

Black allocation discards all old-space free-lists, which may be quite full when
we perform memory reducing GCs.

BUG=chromium:599174
LOG=n

Committed: https://crrev.com/a81c47f35886d88d646d0cf0f4892271a9288389
Cr-Commit-Position: refs/heads/master@{#35374}
==========

[commit-bot: I haz the power, 2016-04-11 09:23:25]

Patchset 5 (id:??) landed as
https://crrev.com/a81c47f35886d88d646d0cf0f4892271a9288389
Cr-Commit-Position: refs/heads/master@{#35374}