kiosk: Defer app update until platform matches

chrome/browser/chromeos/app_mode/kiosk_app_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h"
 
 #include <stddef.h>
 
 #include <utility>
 
 #include "base/barrier_closure.h"
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/path_service.h"
-#include "base/stl_util.h"
+#include "base/strings/stringprintf.h"
 #include "base/sys_info.h"
+#include "base/version.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/app_mode/app_session.h"
 #include "chrome/browser/chromeos/app_mode/kiosk_app_data.h"
 #include "chrome/browser/chromeos/app_mode/kiosk_app_external_loader.h"
 #include "chrome/browser/chromeos/app_mode/kiosk_app_manager_observer.h"
 #include "chrome/browser/chromeos/app_mode/kiosk_external_updater.h"
 #include "chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h"
 #include "chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/policy/device_local_account.h"
@@ skipping 11 matching lines @@
 #include "chromeos/settings/cros_settings_names.h"
 #include "components/ownership/owner_key_util.h"
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service.h"
 #include "components/prefs/scoped_user_pref_update.h"
 #include "components/signin/core/account_id/account_id.h"
 #include "components/user_manager/known_user.h"
 #include "components/user_manager/user_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/common/extension_urls.h"
+#include "extensions/common/manifest_handlers/kiosk_mode_info.h"
 
 namespace chromeos {
 
 namespace {
 
 // Domain that is used for kiosk-app account IDs.
 const char kKioskAppAccountDomain[] = "kiosk-apps";
 
 // Preference for the dictionary of user ids for which cryptohomes have to be
 // removed upon browser restart.
@@ skipping 66 matching lines @@
   *present = util.get() && util->IsPublicKeyPresent();
 }
 
 scoped_refptr<base::SequencedTaskRunner> GetBackgroundTaskRunner() {
   base::SequencedWorkerPool* pool = content::BrowserThread::GetBlockingPool();
   CHECK(pool);
   return pool->GetSequencedTaskRunnerWithShutdownBehavior(
       pool->GetSequenceToken(), base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
 }
 
+base::Version GetPlatformVersion() {
+  int32_t major_version;
+  int32_t minor_version;
+  int32_t bugfix_version;
+  base::SysInfo::OperatingSystemVersionNumbers(&major_version, &minor_version,
+                                               &bugfix_version);
+  return base::Version(base::StringPrintf("%d.%d.%d", major_version,
+                                          minor_version, bugfix_version));
+}
+
 }  // namespace
 
 // static
 const char KioskAppManager::kKioskDictionaryName[] = "kiosk";
 const char KioskAppManager::kKeyApps[] = "apps";
 const char KioskAppManager::kKeyAutoLoginState[] = "auto_login_state";
 const char KioskAppManager::kIconCacheDir[] = "kiosk/icon";
 const char KioskAppManager::kCrxCacheDir[] = "kiosk/crx";
 const char KioskAppManager::kCrxUnpackDir[] = "kiosk_unpack";
 
@@ skipping 414 matching lines @@
 }
 
 void KioskAppManager::PutValidatedExternalExtension(
     const std::string& app_id,
     const base::FilePath& crx_path,
     const std::string& version,
     const ExternalCache::PutExternalExtensionCallback& callback) {
   external_cache_->PutExternalExtension(app_id, crx_path, version, callback);
 }
 
+bool KioskAppManager::IsPlatformCompliant(
+    const std::string& required_platform_version) const {
+  // Empty required version are compliant with any platform version.

[jennyz, 2016/04/19 21:54:28]

nit: are->is?

[xiyuan, 2016/04/19 22:28:45]

Done.

+  if (required_platform_version.empty())
+    return true;
+
+  // Not compliant for bad formatted required versions.
+  const base::Version required_version(required_platform_version);
+  if (!required_version.IsValid() || required_version.components().size() > 3u)

[jennyz, 2016/04/19 21:54:28]

Will it be helpful to add some log for such case? 

[xiyuan, 2016/04/19 22:28:45]

Done.

+    return false;
+
+  // Not compliant if the platform version components do not match.
+  const size_t count = required_version.components().size();
+  const base::Version platform_version = GetPlatformVersion();
+  const auto& platform_version_components = platform_version.components();
+  const auto& required_version_components = required_version.components();
+  for (size_t i = 0; i < count; ++i) {
+    if (platform_version_components[i] != required_version_components[i])
+      return false;
+  }
+
+  return true;
+}
+
+bool KioskAppManager::IsPlatformCompliantWithApp(
+    const extensions::Extension* app) const {
+  // Compliant if the app is not the auto launched with zero delay app.
+  if (currently_auto_launched_with_zero_delay_app_ != app->id())
+    return true;
+
+  // Compliant if the app does not specify required platform version.
+  const extensions::KioskModeInfo* info = extensions::KioskModeInfo::Get(app);
+  if (info == nullptr)
+    return true;
+
+  return IsPlatformCompliant(info->required_platform_version);
+}
+
 KioskAppManager::KioskAppManager()
     : ownership_established_(false),
       external_loader_created_(false),
       secondary_app_external_loader_created_(false) {
   base::FilePath cache_dir;
   GetCrxCacheDir(&cache_dir);
   external_cache_.reset(
       new ExternalCache(cache_dir,
                         g_browser_process->system_request_context(),
                         GetBackgroundTaskRunner(),
@@ skipping 230 matching lines @@
 base::TimeDelta KioskAppManager::GetAutoLaunchDelay() const {
   int delay;
   if (!CrosSettings::Get()->GetInteger(
           kAccountsPrefDeviceLocalAccountAutoLoginDelay, &delay)) {
     return base::TimeDelta();  // Default delay is 0ms.
   }
   return base::TimeDelta::FromMilliseconds(delay);
 }
 
 }  // namespace chromeos