Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Unified Diff: chrome/browser/ui/webui/signin/signin_create_profile_handler.cc

Issue 1869473002: Fixed crash on double profile delete operation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DeleteProfileAtPath use MaybeScheduleProfileForDeletion Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
diff --git a/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc b/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
index a9a6524eb4a2b88763c1f0508e5058b2c4615a2e..f969d05666ec46b2e9699a46c1e3dedf5fcd0b70 100644
--- a/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
+++ b/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
@@ -417,7 +417,9 @@ void SigninCreateProfileHandler::ShowProfileCreationError(
base::StringValue(error));
// The ProfileManager calls us back with a NULL profile in some cases.
if (profile)
Bernhard Bauer 2016/05/12 12:06:23 If the body is now more than one line, add braces.
- webui::DeleteProfileAtPath(profile->GetPath(), web_ui());
+ webui::DeleteProfileAtPath(profile->GetPath(),
+ web_ui(),
+ ProfileMetrics::DELETE_PROFILE_SETTINGS);
profile_creation_type_ = NO_CREATION_IN_PROGRESS;
profile_path_being_created_.clear();
}
@@ -654,7 +656,9 @@ void SigninCreateProfileHandler::CancelProfileRegistration(
// Canceling registration means the callback passed into
// RegisterAndInitSync() won't be called, so the cleanup must be done here.
profile_path_being_created_.clear();
- webui::DeleteProfileAtPath(new_profile->GetPath(), web_ui());
+ webui::DeleteProfileAtPath(new_profile->GetPath(),
+ web_ui(),
+ ProfileMetrics::DELETE_PROFILE_SETTINGS);
}
void SigninCreateProfileHandler::RegisterSupervisedUser(

Powered by Google App Engine
This is Rietveld 408576698