Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: chrome/browser/profiles/profile_manager.cc

Issue 1869473002: Fixed crash on double profile delete operation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DeleteProfileAtPath use MaybeScheduleProfileForDeletion Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_manager.cc
diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profiles/profile_manager.cc
index 9a0ed359e027b479444f1de4e679df58d4132974..27c37c0744cc7a4c5dcbec0b5debb023c540d399 100644
--- a/chrome/browser/profiles/profile_manager.cc
+++ b/chrome/browser/profiles/profile_manager.cc
@@ -726,6 +726,18 @@ ProfileShortcutManager* ProfileManager::profile_shortcut_manager() {
}
#if !defined(OS_ANDROID)
+bool ProfileManager::MaybeScheduleProfileForDeletion(
+ const base::FilePath& profile_dir,
+ const CreateCallback& callback) {
+ if (IsProfileMarkedForDeletion(profile_dir)) {
+ LOG(WARNING) << "Profile already marked for deletion: "
Bernhard Bauer 2016/05/12 12:06:23 I would not warn here if we are returning success
+ << profile_dir.value();
+ return false;
+ }
+ ScheduleProfileForDeletion(profile_dir, callback);
+ return true;
+}
+
void ProfileManager::ScheduleProfileForDeletion(
const base::FilePath& profile_dir,
const CreateCallback& callback) {

Powered by Google App Engine
This is Rietveld 408576698