chrome/browser/profiles/profile_manager.cc - Issue 1869473002: Fixed crash on double profile delete operation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_manager.cc

Issue 1869473002: Fixed crash on double profile delete operation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: patch redone Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/profiles/profile_manager.cc

diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profiles/profile_manager.cc

index 9a0ed359e027b479444f1de4e679df58d4132974..3dc2f377a61be07a54d5752659e1735a63a22bdd 100644

--- a/chrome/browser/profiles/profile_manager.cc

+++ b/chrome/browser/profiles/profile_manager.cc

@@ -1376,8 +1376,8 @@ void ProfileManager::FinishDeletingProfile(

ProfileAttributesEntry* entry;

bool has_entry = storage.GetProfileAttributesWithPath(profile_dir, &entry);

- DCHECK(has_entry);

- ProfileMetrics::LogProfileDelete(entry->IsAuthenticated());

+ if (has_entry)

+ ProfileMetrics::LogProfileDelete(entry->IsAuthenticated());

// Some platforms store passwords in keychains. They should be removed.

scoped_refptr<password_manager::PasswordStore> password_store =

PasswordStoreFactory::GetForProfile(