Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: chrome/browser/profiles/profile_manager.h

Issue 1869473002: Fixed crash on double profile delete operation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review fixes. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_manager.h
diff --git a/chrome/browser/profiles/profile_manager.h b/chrome/browser/profiles/profile_manager.h
index ed8c787a0f7013e2dfebe428f6144f205532acfe..9257706b6b200d41c31322bebd87750c45cac747 100644
--- a/chrome/browser/profiles/profile_manager.h
+++ b/chrome/browser/profiles/profile_manager.h
@@ -22,6 +22,7 @@
#include "base/threading/non_thread_safe.h"
#include "build/build_config.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_metrics.h"
#include "chrome/browser/profiles/profile_shortcut_manager.h"
#include "chrome/browser/ui/browser_list_observer.h"
#include "content/public/browser/notification_observer.h"
@@ -189,6 +190,13 @@ class ProfileManager : public base::NonThreadSafe,
ProfileShortcutManager* profile_shortcut_manager();
#if !defined(OS_ANDROID)
+ // Less strict version of ScheduleProfileForDeletion(), silently fail if
+ // profile already marked for deletion. Returns true if the profile scheduled
+ // for deletion.
+ bool MaybeScheduleProfileForDeletion(const base::FilePath& profile_dir,
+ const CreateCallback& callback,
+ ProfileMetrics::ProfileDelete user);
+
// Schedules the profile at the given path to be deleted on shutdown. If we're
// deleting the last profile, a new one will be created in its place, and in
// that case the callback will be called when profile creation is complete.
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_manager.cc » ('j') | chrome/browser/ui/webui/profile_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698