Fixed crash on double profile delete operation.

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <stdint.h>
 
 #include <set>
 #include <string>
@@ skipping 708 matching lines @@
 
 ProfileAttributesStorage& ProfileManager::GetProfileAttributesStorage() {
   return GetProfileInfoCache();
 }
 
 ProfileShortcutManager* ProfileManager::profile_shortcut_manager() {
   return profile_shortcut_manager_.get();
 }
 
 #if !defined(OS_ANDROID)
+bool ProfileManager::MaybeScheduleProfileForDeletion(
+    const base::FilePath& profile_dir,
+    const CreateCallback& callback) {
+  if (IsProfileMarkedForDeletion(profile_dir))
+    return false;
+  ScheduleProfileForDeletion(profile_dir, callback);
+  return true;
+}
+
 void ProfileManager::ScheduleProfileForDeletion(
     const base::FilePath& profile_dir,
     const CreateCallback& callback) {
   DCHECK(profiles::IsMultipleProfilesEnabled());
+  CHECK(!IsProfileMarkedForDeletion(profile_dir));

[Dan Beam, 2016/05/13 03:37:40]

sooooo, why can't we just do:

if (IsProfileMarkedForDeletion(profile_dir)) {
  // do something with callback, i.e. append to a list or Run()
  return;
}

this method is just asking that it be scheduled for deletion.  if it's already
scheduled, i don't really see the harm...

[Bernhard Bauer, 2016/05/13 09:37:54]

I would make this a DCHECK though.

 
   // Cancel all in-progress downloads before deleting the profile to prevent a
   // "Do you want to exit Google Chrome and cancel the downloads?" prompt
   // (crbug.com/336725).
   Profile* profile = GetProfileByPath(profile_dir);
   if (profile) {
     DownloadService* service =
         DownloadServiceFactory::GetForBrowserContext(profile);
     service->CancelDownloads();
   }
@@ skipping 881 matching lines @@
 
   FinishDeletingProfile(profile_to_delete_path, new_active_profile_path);
   if (!original_callback.is_null())
     original_callback.Run(loaded_profile, status);
 }
 #endif  // !defined(OS_ANDROID)
 
 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
     const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) {
 }