Fixed crash on double profile delete operation.

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <stdint.h>
 
 #include <set>
 #include <string>
@@ skipping 1356 matching lines @@
         // Record sync stopped by profile destruction if it was on before.
         UMA_HISTOGRAM_ENUMERATION("Sync.StopSource",
                                   syncer::PROFILE_DESTRUCTION,
                                   syncer::STOP_SOURCE_LIMIT);
       }
       // Ensure data is cleared even if sync was already off.
       ProfileSyncServiceFactory::GetInstance()->GetForProfile(
           profile)->RequestStop(ProfileSyncService::CLEAR_DATA);
     }
 
-    ProfileMetrics::LogProfileDelete(cache.ProfileIsAuthenticatedAtIndex(
-        cache.GetIndexOfProfileWithPath(profile_dir)));
+    size_t profile_index = cache.GetIndexOfProfileWithPath(profile_dir);

[anthonyvd, 2016/04/12 17:29:16]

Can you use the new ProfileAttributesStorage interface
(https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...)
please? Should be a drop-in replacement.

+    if (profile_index != std::string::npos) {
+      ProfileMetrics::LogProfileDelete(
+          cache.ProfileIsAuthenticatedAtIndex(profile_index));
+    } else {
+      NOTREACHED();
+    }
     // Some platforms store passwords in keychains. They should be removed.
     scoped_refptr<password_manager::PasswordStore> password_store =
         PasswordStoreFactory::GetForProfile(
             profile, ServiceAccessType::EXPLICIT_ACCESS).get();
     if (password_store.get()) {
       password_store->RemoveLoginsCreatedBetween(
           base::Time(), base::Time::Max(), base::Closure());
     }
 
     // The Profile Data doesn't get wiped until Chrome closes. Since we promised
@@ skipping 228 matching lines @@
 
   FinishDeletingProfile(profile_to_delete_path, new_active_profile_path);
   if (!original_callback.is_null())
     original_callback.Run(loaded_profile, status);
 }
 #endif  // !defined(OS_ANDROID)
 
 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
     const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) {
 }