Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1869463002: Set last cursor default to kCursorNone (Closed)

Created:
4 years, 8 months ago by dnicoara
Modified:
4 years, 8 months ago
Reviewers:
rjkroege, sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-cursor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set last cursor default to kCursorNone This makes the last set cursor as hidden. Since MUS is controlling the cursor (and managing the cursor resources), starting with a hidden cursor is better as MUS can control the cursor interaction end-to-end. Also, when running MUS as the display manager, MUS is in charge of setting the default cursor, so there is no underlying window manager to set the cursor initially (the initial cursor state is invisible). On multi-display configurations the expected behavior is to start with a hidden cursor on new displays. BUG=600811 Committed: https://crrev.com/c82ddf12fd204b7ad9d684049f32ee42952a66f7 Cr-Commit-Position: refs/heads/master@{#385809}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/mus/ws/display.cc View 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
dnicoara
PTAL
4 years, 8 months ago (2016-04-06 15:39:27 UTC) #4
rjkroege
lgtm
4 years, 8 months ago (2016-04-06 15:47:40 UTC) #5
sky
LGTM
4 years, 8 months ago (2016-04-07 17:23:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869463002/20001
4 years, 8 months ago (2016-04-07 17:25:46 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 18:15:55 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 18:17:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c82ddf12fd204b7ad9d684049f32ee42952a66f7
Cr-Commit-Position: refs/heads/master@{#385809}

Powered by Google App Engine
This is Rietveld 408576698