Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 186943003: Add layout test which checks sticky postioning when overflow is scrolled by fragment. (Closed)

Created:
6 years, 9 months ago by ostap
Modified:
6 years, 9 months ago
Reviewers:
Inactive, ojan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add layout test which checks sticky postioning when overflow is scrolled by fragment. Related to this w3c mailing list thread: http://lists.w3.org/Archives/Public/www-style/2014Mar/0013.html BUG=231754 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168528

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix indentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -13 lines) Patch
A + LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html View 1 5 chunks +31 lines, -10 lines 0 comments Download
A + LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment-expected.html View 4 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ostap
6 years, 9 months ago (2014-03-04 20:22:42 UTC) #1
ojan
lgtm https://codereview.chromium.org/186943003/diff/1/LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html File LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html (right): https://codereview.chromium.org/186943003/diff/1/LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html#newcode11 LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html:11: if (window.location.hash == '') { Indentation is inconsistent ...
6 years, 9 months ago (2014-03-05 02:53:26 UTC) #2
ostap
https://codereview.chromium.org/186943003/diff/1/LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html File LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html (right): https://codereview.chromium.org/186943003/diff/1/LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html#newcode11 LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html:11: if (window.location.hash == '') { On 2014/03/05 02:53:26, ojan ...
6 years, 9 months ago (2014-03-05 05:04:28 UTC) #3
ostap
The CQ bit was checked by sl.ostapenko@samsung.com
6 years, 9 months ago (2014-03-05 05:04:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/186943003/20001
6 years, 9 months ago (2014-03-05 05:05:28 UTC) #5
ostap
The CQ bit was unchecked by sl.ostapenko@samsung.com
6 years, 9 months ago (2014-03-05 18:03:39 UTC) #6
ostap
The CQ bit was checked by sl.ostapenko@samsung.com
6 years, 9 months ago (2014-03-05 18:03:51 UTC) #7
ostap
On 2014/03/05 18:03:51, ostap wrote: > The CQ bit was checked by mailto:sl.ostapenko@samsung.com Commit bot ...
6 years, 9 months ago (2014-03-05 18:04:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/186943003/20001
6 years, 9 months ago (2014-03-05 18:04:27 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 20:40:03 UTC) #10
Message was sent while issue was closed. 
Change committed as 168528

Powered by Google App Engine
This is Rietveld 408576698