Plumbing maxTouchPoints for Android.

Plumbing maxTouchPoints for Android.

Filled in Android implementation for navigator.maxTouchPoints defined
in the W3C Pointer Events standard draft:
http://www.w3.org/TR/pointerevents/#widl-Navigator-maxTouchPoints

BUG=248918
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255553

[bokan, 2014-03-04 19:34:56]

tedchoc@, Please review the Java/JNI bits
sadrul@, Please review touch changes

Thanks

[sadrul, 2014-03-05 18:54:37]

On 2014/03/04 19:34:56, bokan wrote:
> tedchoc@, Please review the Java/JNI bits
> sadrul@, Please review touch changes
> 
> Thanks

I will rubberstamp after tedchoc@'s review.

[Ted C, 2014-03-05 21:14:25]

a few little comments

maybe sadrul can comment on the header stuff as this might be the preferred way
to do it in ui/

https://codereview.chromium.org/186943002/diff/10001/ui/android/java/src/org/...
File ui/android/java/src/org/chromium/ui/base/TouchDevice.java (right):

https://codereview.chromium.org/186943002/diff/10001/ui/android/java/src/org/...
ui/android/java/src/org/chromium/ui/base/TouchDevice.java:1: // Copyright 2013
The Chromium Authors. All rights reserved.
2014

https://codereview.chromium.org/186943002/diff/10001/ui/android/java/src/org/...
ui/android/java/src/org/chromium/ui/base/TouchDevice.java:17: public class
TouchDevice {
since this only contains statics, maybe make a private constructor to avoid
creation.

https://codereview.chromium.org/186943002/diff/10001/ui/android/java/src/org/...
ui/android/java/src/org/chromium/ui/base/TouchDevice.java:30:
PackageManager.FEATURE_TOUCHSCREEN_MULTITOUCH_JAZZHAND)) {
Ha!  Best constant name ever.

https://codereview.chromium.org/186943002/diff/10001/ui/base/touch/touch_devi...
File ui/base/touch/touch_device_android.cc (right):

https://codereview.chromium.org/186943002/diff/10001/ui/base/touch/touch_devi...
ui/base/touch/touch_device_android.cc:8: #include
"ui/base/touch/touch_device_android_initialization.h"
hmm...this name is a bit odd to me.  I might just use touch_device_android.h.

Or maybe just ifdef the registration method in the base header.

https://codereview.chromium.org/186943002/diff/10001/ui/base/touch/touch_devi...
ui/base/touch/touch_device_android.cc:10: using namespace base::android;
Since the usage is pretty small, I would leave this out and use base::android 
everywhere.

https://codereview.chromium.org/186943002/diff/10001/ui/base/touch/touch_devi...
ui/base/touch/touch_device_android.cc:20: DCHECK(env);
Do we DCHECK any other usages of AttachCurrentThread or GetApplicationContext? 
I'm thinking you can leave them out if no other place checks.

https://codereview.chromium.org/186943002/diff/10001/ui/base/touch/touch_devi...
File ui/base/touch/touch_device_android_initialization.h (right):

https://codereview.chromium.org/186943002/diff/10001/ui/base/touch/touch_devi...
ui/base/touch/touch_device_android_initialization.h:1: // Copyright (c) 2013 The
Chromium Authors. All rights reserved.
2014

[bokan, 2014-03-05 22:49:20]

Feedback addressed. PTAL

https://codereview.chromium.org/186943002/diff/10001/ui/android/java/src/org/...
File ui/android/java/src/org/chromium/ui/base/TouchDevice.java (right):

https://codereview.chromium.org/186943002/diff/10001/ui/android/java/src/org/...
ui/android/java/src/org/chromium/ui/base/TouchDevice.java:1: // Copyright 2013
The Chromium Authors. All rights reserved.
On 2014/03/05 21:14:26, Ted C wrote:
> 2014

Done.

https://codereview.chromium.org/186943002/diff/10001/ui/android/java/src/org/...
ui/android/java/src/org/chromium/ui/base/TouchDevice.java:17: public class
TouchDevice {
On 2014/03/05 21:14:26, Ted C wrote:
> since this only contains statics, maybe make a private constructor to avoid
> creation.

Done.

https://codereview.chromium.org/186943002/diff/10001/ui/base/touch/touch_devi...
File ui/base/touch/touch_device_android.cc (right):

https://codereview.chromium.org/186943002/diff/10001/ui/base/touch/touch_devi...
ui/base/touch/touch_device_android.cc:8: #include
"ui/base/touch/touch_device_android_initialization.h"
On 2014/03/05 21:14:26, Ted C wrote:
> hmm...this name is a bit odd to me.  I might just use touch_device_android.h.
> 
> Or maybe just ifdef the registration method in the base header.

Went with the latter.

https://codereview.chromium.org/186943002/diff/10001/ui/base/touch/touch_devi...
ui/base/touch/touch_device_android.cc:10: using namespace base::android;
On 2014/03/05 21:14:26, Ted C wrote:
> Since the usage is pretty small, I would leave this out and use base::android 
> everywhere.

Done.

https://codereview.chromium.org/186943002/diff/10001/ui/base/touch/touch_devi...
ui/base/touch/touch_device_android.cc:20: DCHECK(env);
On 2014/03/05 21:14:26, Ted C wrote:
> Do we DCHECK any other usages of AttachCurrentThread or GetApplicationContext?

> I'm thinking you can leave them out if no other place checks.

Done.

https://codereview.chromium.org/186943002/diff/10001/ui/base/touch/touch_devi...
File ui/base/touch/touch_device_android_initialization.h (right):

https://codereview.chromium.org/186943002/diff/10001/ui/base/touch/touch_devi...
ui/base/touch/touch_device_android_initialization.h:1: // Copyright (c) 2013 The
Chromium Authors. All rights reserved.
On 2014/03/05 21:14:26, Ted C wrote:
> 2014

Removed this file.

[Ted C, 2014-03-05 22:50:38]

lgtm

[sadrul, 2014-03-05 23:59:53]

lgtm

[bokan, 2014-03-06 00:27:33]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2014-03-06 00:31:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bokan@chromium.org/186943002/30001

[commit-bot: I haz the power, 2014-03-06 01:20:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 01:20:29]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[bokan, 2014-03-06 14:31:43]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2014-03-06 14:32:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bokan@chromium.org/186943002/30001

[commit-bot: I haz the power, 2014-03-06 15:43:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 15:43:38]

Retried try job too often on win_rel for step(s) net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[bokan, 2014-03-06 16:41:35]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2014-03-06 16:43:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bokan@chromium.org/186943002/30001

[commit-bot: I haz the power, 2014-03-06 19:47:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 19:47:10]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[bokan, 2014-03-06 20:10:18]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2014-03-06 20:49:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bokan@chromium.org/186943002/30001

[commit-bot: I haz the power, 2014-03-06 21:38:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bokan@chromium.org/186943002/30001

[commit-bot: I haz the power, 2014-03-06 22:13:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bokan@chromium.org/186943002/30001

[commit-bot: I haz the power, 2014-03-07 08:54:13]

Change committed as 255553