Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 18694004: Plug some memory leaks in parser tests. (Closed)

Created:
7 years, 5 months ago by earthdok
Modified:
7 years, 5 months ago
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Plug some memory leaks in parser tests. BUG=v8:2763 R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15490

Patch Set 1 #

Total comments: 3

Patch Set 2 : use ScopedVector #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M test/cctest/test-parsing.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
earthdok
please take a look
7 years, 5 months ago (2013-07-04 13:45:53 UTC) #1
Michael Starzinger
Dmitry kindly offered to take a look at this one.
7 years, 5 months ago (2013-07-04 15:06:29 UTC) #2
Dmitry Lomov (no reviews)
https://codereview.chromium.org/18694004/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/18694004/diff/1/test/cctest/test-parsing.cc#newcode1076 test/cctest/test-parsing.cc:1076: i::DeleteArray(message); Not too happy about explicit deletions here - ...
7 years, 5 months ago (2013-07-04 15:22:29 UTC) #3
earthdok
https://codereview.chromium.org/18694004/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/18694004/diff/1/test/cctest/test-parsing.cc#newcode1299 test/cctest/test-parsing.cc:1299: i::DeleteArray(program.start()); On 2013/07/04 15:22:29, Dmitry Lomov (chromium) wrote: > ...
7 years, 5 months ago (2013-07-04 15:31:13 UTC) #4
Dmitry Lomov (no reviews)
lgtm
7 years, 5 months ago (2013-07-04 15:35:22 UTC) #5
earthdok
On 2013/07/04 15:35:22, Dmitry Lomov (chromium) wrote: > lgtm I don't have committer access. Can ...
7 years, 5 months ago (2013-07-04 15:45:30 UTC) #6
Dmitry Lomov (no reviews)
On 2013/07/04 15:45:30, earthdok wrote: > On 2013/07/04 15:35:22, Dmitry Lomov (chromium) wrote: > > ...
7 years, 5 months ago (2013-07-04 15:46:18 UTC) #7
Dmitry Lomov (no reviews)
7 years, 5 months ago (2013-07-04 15:57:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r15490 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698