Issue 18694002: Improve forwarder2 setup/tear down in telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18694002: Improve forwarder2 setup/tear down in telemetry. (Closed)

Created:
7 years, 5 months ago by Philippe

Modified:
7 years, 5 months ago

Reviewers:
bulach, tonyg

CC:
chromium-reviews, craigdh+watch_chromium.org, chrome-speed-team+watch_google.com, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, telemetry+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improve forwarder2 setup/tear down in telemetry. This CL kills the host_forwarder daemon before running the tests and also makes Forwarder.Close() unmap the previously mapped ports. BUG=242846 R=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210268

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -20 lines)			Patch
M	build/android/bb_run_sharded_steps.py	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	build/android/pylib/forwarder.py	View	1	4 chunks	+27 lines, -14 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/adb_commands.py	View		1 chunk	+14 lines, -5 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/android_browser_backend.py	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm, thanks! just FYI on what to keep an eye on :) the bb_sharded_perf_tests.py is ...

7 years, 5 months ago (2013-07-04 16:27:04 UTC) #2

Philippe

On 2013/07/04 16:27:04, bulach wrote: > lgtm, thanks! > > just FYI on what to ...

7 years, 5 months ago (2013-07-05 06:58:37 UTC) #3

Philippe

7 years, 5 months ago (2013-07-05 07:05:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r210268 (presubmit successful).

Expand Messages | Collapse Messages