Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1869383004:
Add a content setting property to disable first-use popups. (Closed)
DescriptionAdd a content setting property to disable first-use popups.
For reference:
http://developer.android.com/reference/android/provider/Settings.Secure.html#SKIP_FIRST_USE_HINTS
BUG=
Committed: https://crrev.com/b6b66cba1eb7a6a66165f7e6ad8aa4d30c060436
Cr-Commit-Position: refs/heads/master@{#386713}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
Description was changed from ========== Add a content setting property to disable first-use popups. BUG= ========== to ========== Add a content setting property to disable first-use popups. For reference: http://developer.android.com/reference/android/provider/Settings.Secure.html#... BUG= ==========
bpastene@chromium.org changed reviewers: + mikecase@chromium.org, rnephew@chromium.org
ptal
On 2016/04/09 00:02:00, bpastene wrote: > ptal lgtm
The CQ bit was checked by bpastene@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869383004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by bpastene@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869383004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by bpastene@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869383004/1
Message was sent while issue was closed.
Description was changed from ========== Add a content setting property to disable first-use popups. For reference: http://developer.android.com/reference/android/provider/Settings.Secure.html#... BUG= ========== to ========== Add a content setting property to disable first-use popups. For reference: http://developer.android.com/reference/android/provider/Settings.Secure.html#... BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add a content setting property to disable first-use popups. For reference: http://developer.android.com/reference/android/provider/Settings.Secure.html#... BUG= ========== to ========== Add a content setting property to disable first-use popups. For reference: http://developer.android.com/reference/android/provider/Settings.Secure.html#... BUG= Committed: https://crrev.com/b6b66cba1eb7a6a66165f7e6ad8aa4d30c060436 Cr-Commit-Position: refs/heads/master@{#386713} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b6b66cba1eb7a6a66165f7e6ad8aa4d30c060436 Cr-Commit-Position: refs/heads/master@{#386713} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
