Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5390)

Unified Diff: chrome/installer/util/conditional_work_item_list_unittest.cc

Issue 1869383003: Simplify WorkItemListTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: no inline destructors Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/BUILD.gn ('k') | chrome/installer/util/work_item_list_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/conditional_work_item_list_unittest.cc
diff --git a/chrome/installer/util/conditional_work_item_list_unittest.cc b/chrome/installer/util/conditional_work_item_list_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1268f5dfbea1e54b5b2eb8eb46281d1a3d23aed5
--- /dev/null
+++ b/chrome/installer/util/conditional_work_item_list_unittest.cc
@@ -0,0 +1,129 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/installer/util/conditional_work_item_list.h"
+
+#include <memory>
+
+#include "base/files/file_path.h"
+#include "base/files/scoped_temp_dir.h"
+#include "base/macros.h"
+#include "chrome/installer/util/work_item.h"
+#include "chrome/installer/util/work_item_mocks.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::InSequence;
+using testing::Return;
+
+// Execute a ConditionalWorkItemList whose condition is met and then rollback.
+TEST(ConditionalWorkItemListTest, ExecutionSuccess) {
+ std::unique_ptr<StrictMockCondition> condition(new StrictMockCondition);
+ EXPECT_CALL(*condition, ShouldRun()).WillOnce(Return(true));
+ std::unique_ptr<WorkItemList> list(
+ WorkItem::CreateConditionalWorkItemList(condition.release()));
+
+ // Create the mock work items.
+ std::unique_ptr<StrictMockWorkItem> item1(new StrictMockWorkItem);
+ std::unique_ptr<StrictMockWorkItem> item2(new StrictMockWorkItem);
+ std::unique_ptr<StrictMockWorkItem> item3(new StrictMockWorkItem);
+
+ {
+ // Expect all three items to be done in order then undone.
+ InSequence s;
+
+ EXPECT_CALL(*item1, Do()).WillOnce(Return(true));
+ EXPECT_CALL(*item2, Do()).WillOnce(Return(true));
+ EXPECT_CALL(*item3, Do()).WillOnce(Return(true));
+ EXPECT_CALL(*item3, Rollback());
+ EXPECT_CALL(*item2, Rollback());
+ EXPECT_CALL(*item1, Rollback());
+ }
+
+ // Add the items to the list.
+ list->AddWorkItem(item1.release());
+ list->AddWorkItem(item2.release());
+ list->AddWorkItem(item3.release());
+
+ // Do and rollback the list.
+ EXPECT_TRUE(list->Do());
+ list->Rollback();
+}
+
+// Execute a ConditionalWorkItemList whose condition is met. Fail in the middle.
+// Rollback what has been done.
+TEST(ConditionalWorkItemListTest, ExecutionFailAndRollback) {
+ std::unique_ptr<StrictMockCondition> condition(new StrictMockCondition);
+ EXPECT_CALL(*condition, ShouldRun()).WillOnce(Return(true));
+ std::unique_ptr<WorkItemList> list(
+ WorkItem::CreateConditionalWorkItemList(condition.release()));
+
+ // Create the mock work items.
+ std::unique_ptr<StrictMockWorkItem> item1(new StrictMockWorkItem);
+ std::unique_ptr<StrictMockWorkItem> item2(new StrictMockWorkItem);
+ std::unique_ptr<StrictMockWorkItem> item3(new StrictMockWorkItem);
+
+ {
+ // Expect the two first work items to be done in order then undone.
+ InSequence s;
+
+ EXPECT_CALL(*item1, Do()).WillOnce(Return(true));
+ EXPECT_CALL(*item2, Do()).WillOnce(Return(false));
+ EXPECT_CALL(*item2, Rollback());
+ EXPECT_CALL(*item1, Rollback());
+ }
+
+ // Add the items to the list.
+ list->AddWorkItem(item1.release());
+ list->AddWorkItem(item2.release());
+ list->AddWorkItem(item3.release());
+
+ // Do and rollback the list.
+ EXPECT_FALSE(list->Do());
+ list->Rollback();
+}
+
+// Execute a ConditionalWorkItemList whose condition isn't met.
+TEST(ConditionalWorkItemListTest, ConditionFailure) {
+ std::unique_ptr<StrictMockCondition> condition(new StrictMockCondition);
+ EXPECT_CALL(*condition, ShouldRun()).WillOnce(Return(false));
+ std::unique_ptr<WorkItemList> list(
+ WorkItem::CreateConditionalWorkItemList(condition.release()));
+
+ // Create the mock work items.
+ std::unique_ptr<StrictMockWorkItem> item1(new StrictMockWorkItem);
+ std::unique_ptr<StrictMockWorkItem> item2(new StrictMockWorkItem);
+ std::unique_ptr<StrictMockWorkItem> item3(new StrictMockWorkItem);
+
+ // Don't expect any call to the methods of the work items.
+
+ // Add the items to the list.
+ list->AddWorkItem(item1.release());
+ list->AddWorkItem(item2.release());
+ list->AddWorkItem(item3.release());
+
+ // Do and rollback the list.
+ EXPECT_TRUE(list->Do());
+ list->Rollback();
+}
+
+TEST(ConditionalWorkItemListTest, ConditionNot) {
+ std::unique_ptr<StrictMockCondition> condition_true(new StrictMockCondition);
+ EXPECT_CALL(*condition_true, ShouldRun()).WillOnce(Return(true));
+ EXPECT_FALSE(Not(condition_true.release()).ShouldRun());
+
+ std::unique_ptr<StrictMockCondition> condition_false(new StrictMockCondition);
+ EXPECT_CALL(*condition_false, ShouldRun()).WillOnce(Return(false));
+ EXPECT_TRUE(Not(condition_false.release()).ShouldRun());
+}
+
+TEST(ConditionalWorkItemListTest, ConditionRunIfFileExists) {
+ base::ScopedTempDir temp_dir;
+ ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
+
+ EXPECT_TRUE(ConditionRunIfFileExists(temp_dir.path()).ShouldRun());
+ EXPECT_FALSE(ConditionRunIfFileExists(
+ temp_dir.path().Append(FILE_PATH_LITERAL("DoesNotExist")))
+ .ShouldRun());
+}
« no previous file with comments | « chrome/installer/util/BUILD.gn ('k') | chrome/installer/util/work_item_list_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698