Replace LateConstInvokeStructure after analysis.

Replace LateConstInvokeStructure after analysis.

This is in preparation for serialization.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/a6b61035c998c2c4b1c7a0be2f400a59653e827c

[Johnni Winther, 2016-04-08 14:16:29]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-04-08 16:10:45]

lgtm

https://codereview.chromium.org/1869383002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1869383002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:4091:
registry.registerNewStructure(node, structure);
do we need to register it if we are replacing it later?

https://codereview.chromium.org/1869383002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:4151: void onAnalyzed()}) {
... eventually we should consider using futures in cases like these where we are
just waiting for the async work to be done.

[Johnni Winther, 2016-04-11 07:40:46]

https://codereview.chromium.org/1869383002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1869383002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:4091:
registry.registerNewStructure(node, structure);
On 2016/04/08 16:10:45, Siggi Cherem (dart-lang) wrote:
> do we need to register it if we are replacing it later?

I'm not sure. Adding a TODO for trying in a follow CL:

https://codereview.chromium.org/1869383002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:4151: void onAnalyzed()}) {
On 2016/04/08 16:10:45, Siggi Cherem (dart-lang) wrote:
> ... eventually we should consider using futures in cases like these where we
are
> just waiting for the async work to be done.

Acknowledged.

[Johnni Winther, 2016-04-11 07:55:04]

Description was changed from

==========
Replace LateConstInvokeStructure after analysis.

This is in preparation for serialization.
==========

to

==========
Replace LateConstInvokeStructure after analysis.

This is in preparation for serialization.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a6b61035c998c2c4b1c7a0be2f400a59653e827c
==========

[Johnni Winther, 2016-04-11 07:55:06]

Committed patchset #4 (id:60001) manually as
a6b61035c998c2c4b1c7a0be2f400a59653e827c (presubmit successful).