Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/eval_gc_time.sh

Issue 1869353002: [tools] Compute percentiles for GC NVP (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/eval_gc_nvp.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/eval_gc_time.sh
diff --git a/tools/eval_gc_time.sh b/tools/eval_gc_time.sh
index ceb4db54cb4606796c83b8a8983169526f56c9ac..36083ba77f43b5877985cd4bdaf3cd5e5fbe4676 100755
--- a/tools/eval_gc_time.sh
+++ b/tools/eval_gc_time.sh
@@ -17,6 +17,7 @@ print_usage_and_die() {
echo " -c|--csv provide csv output"
echo " -f|--file FILE profile input in a file"
echo " (default: stdin)"
+ echo " -p|--percentiles comma separated percentiles"
exit 1
}
@@ -25,6 +26,7 @@ RANK_MODE=max
TOP_LEVEL=no
CSV=""
LOGFILE=/dev/stdin
+PERCENTILES=""
while [[ $# -ge 1 ]]
do
@@ -60,6 +62,10 @@ do
LOGFILE=$2
shift
;;
+ -f|--percentiles)
+ PERCENTILES="--percentiles=$2"
+ shift
+ ;;
*)
break
;;
@@ -145,6 +151,7 @@ case $OP in
--no-histogram \
--rank $RANK_MODE \
$CSV \
+ $PERCENTILES \
${INTERESTING_NEW_GEN_KEYS}
;;
old-gen-rank)
@@ -153,6 +160,7 @@ case $OP in
--no-histogram \
--rank $RANK_MODE \
$CSV \
+ $PERCENTILES \
${INTERESTING_OLD_GEN_KEYS}
;;
*)
« no previous file with comments | « tools/eval_gc_nvp.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698