Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1869343003: MIPS64: Fix '[generators] Decouple generator resume from fullcodegen.' (Closed)

Created:
4 years, 8 months ago by Marija Antic
Modified:
4 years, 8 months ago
Reviewers:
ivica.bogosavljevic, ilija.pavlovic, balazs.kilvady, miran.karic, Benedikt Meurer, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix '[generators] Decouple generator resume from fullcodegen.' Fix for multiple test failures occurring since ResumeGeneratorTrampoline was introduced with the change 974721c66131d208571b8759a1caadf7f995c54c. BUG= Committed: https://crrev.com/a39544b674e9392d25fe7f6f82f27dbf8d0f9267 Cr-Commit-Position: refs/heads/master@{#35373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/mips64/builtins-mips64.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
akos.palfi.imgtec
LGTM if nit is addressed: The title should be: MIPS64: Fix '[generators] Decouple generator resume ...
4 years, 8 months ago (2016-04-08 14:55:53 UTC) #2
Marija Antic
PTAL
4 years, 8 months ago (2016-04-11 07:28:31 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869343003/1
4 years, 8 months ago (2016-04-11 08:46:54 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 09:05:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869343003/1
4 years, 8 months ago (2016-04-11 09:07:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 09:09:25 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 09:09:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a39544b674e9392d25fe7f6f82f27dbf8d0f9267
Cr-Commit-Position: refs/heads/master@{#35373}

Powered by Google App Engine
This is Rietveld 408576698