Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 8 months ago by Marija Antic Modified:
4 years, 8 months ago Reviewers:
ivica.bogosavljevic, ilija.pavlovic, balazs.kilvady, miran.karic, Benedikt Meurer, akos.palfi.imgtec CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionMIPS64: Fix '[generators] Decouple generator resume from fullcodegen.'
Fix for multiple test failures occurring since ResumeGeneratorTrampoline
was introduced with the change 974721c66131d208571b8759a1caadf7f995c54c.
BUG=
Committed: https://crrev.com/a39544b674e9392d25fe7f6f82f27dbf8d0f9267
Cr-Commit-Position: refs/heads/master@{#35373}
Patch Set 1 #
Created: 4 years, 8 months ago
Messages
Total messages: 15 (8 generated)
akos.palfi@imgtec.com changed reviewers: + akos.palfi@imgtec.com
LGTM if nit is addressed: The title should be: MIPS64: Fix '[generators] Decouple generator resume from fullcodegen.' Please add the original author as a reviewer.
Description was changed from ========== MIPS64: Fix Builtins::Generate_ResumeGeneratorTrampoline Fix for multiple test failures occurring since ResumeGeneratorTrampoline was introduced with the change 974721c66131d208571b8759a1caadf7f995c54c. BUG= ========== to ========== MIPS64: Fix '[generators] Decouple generator resume from fullcodegen.' Fix for multiple test failures occurring since ResumeGeneratorTrampoline was introduced with the change 974721c66131d208571b8759a1caadf7f995c54c. BUG= ==========
PTAL
The CQ bit was checked by marija.antic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869343003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by marija.antic@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869343003/1
Message was sent while issue was closed.
Description was changed from ========== MIPS64: Fix '[generators] Decouple generator resume from fullcodegen.' Fix for multiple test failures occurring since ResumeGeneratorTrampoline was introduced with the change 974721c66131d208571b8759a1caadf7f995c54c. BUG= ========== to ========== MIPS64: Fix '[generators] Decouple generator resume from fullcodegen.' Fix for multiple test failures occurring since ResumeGeneratorTrampoline was introduced with the change 974721c66131d208571b8759a1caadf7f995c54c. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== MIPS64: Fix '[generators] Decouple generator resume from fullcodegen.' Fix for multiple test failures occurring since ResumeGeneratorTrampoline was introduced with the change 974721c66131d208571b8759a1caadf7f995c54c. BUG= ========== to ========== MIPS64: Fix '[generators] Decouple generator resume from fullcodegen.' Fix for multiple test failures occurring since ResumeGeneratorTrampoline was introduced with the change 974721c66131d208571b8759a1caadf7f995c54c. BUG= Committed: https://crrev.com/a39544b674e9392d25fe7f6f82f27dbf8d0f9267 Cr-Commit-Position: refs/heads/master@{#35373} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a39544b674e9392d25fe7f6f82f27dbf8d0f9267 Cr-Commit-Position: refs/heads/master@{#35373} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
