Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1869243002: Fix the issue that client id is not saved when upgrading the offline metadata store (Closed)

Created:
4 years, 8 months ago by jianli
Modified:
4 years, 8 months ago
Reviewers:
bburns, fgorski
CC:
chromium-reviews, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the issue that client id is not saved when upgrading the offline metadata store BUG=601071 Committed: https://crrev.com/5c4aada470737b1708ab65a92e5116634c67550c Cr-Commit-Position: refs/heads/master@{#386167}

Patch Set 1 : Patch #

Total comments: 1

Patch Set 2 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -22 lines) Patch
M components/offline_pages/offline_page_metadata_store_impl.h View 2 chunks +2 lines, -5 lines 0 comments Download
M components/offline_pages/offline_page_metadata_store_impl.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M components/offline_pages/offline_page_metadata_store_impl_unittest.cc View 8 chunks +65 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jianli
4 years, 8 months ago (2016-04-07 23:52:50 UTC) #3
fgorski
lgtm https://codereview.chromium.org/1869243002/diff/20001/components/offline_pages/offline_page_metadata_store_impl.cc File components/offline_pages/offline_page_metadata_store_impl.cc (right): https://codereview.chromium.org/1869243002/diff/20001/components/offline_pages/offline_page_metadata_store_impl.cc#newcode185 components/offline_pages/offline_page_metadata_store_impl.cc:185: keys_to_remove->push_back(item.client_id.id); nit: Add a comment that his is ...
4 years, 8 months ago (2016-04-08 05:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869243002/40001
4 years, 8 months ago (2016-04-08 19:06:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-08 19:53:39 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 19:54:38 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c4aada470737b1708ab65a92e5116634c67550c
Cr-Commit-Position: refs/heads/master@{#386167}

Powered by Google App Engine
This is Rietveld 408576698