Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json

Issue 1869223002: [Findit] Use results from heuristic analysis to do faster culprit finding. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@setup_local_test
Patch Set: Fix nit. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json
diff --git a/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json b/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json
similarity index 92%
copy from scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json
copy to scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json
index 3faaee6f53a6273eb68c3ad8de71e30156064de1..0afb5a4b46ab9c7a4d6cd330a9da63374c8c463e 100644
--- a/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json
+++ b/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json
@@ -21,7 +21,7 @@
"--output_json",
"/path/to/tmp/json",
"--revision",
- "src@r1",
+ "src@r5",
"--output_manifest"
],
"cwd": "[SLAVE_BUILD]",
@@ -34,7 +34,7 @@
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"did_run\": true, @@@",
"@@@STEP_LOG_LINE@json.output@ \"fixed_revisions\": {@@@",
- "@@@STEP_LOG_LINE@json.output@ \"src\": \"r1\"@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"src\": \"r5\"@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"manifest\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"src\": {@@@",
@@ -182,20 +182,23 @@
"git",
"log",
"--format=%H",
- "r0..r1"
+ "r1..r5"
],
"cwd": "[SLAVE_BUILD]/src",
"name": "git commits in range",
"stdout": "/path/to/tmp/",
"~followup_annotations": [
- "@@@STEP_LOG_LINE@revisions@r1@@@",
+ "@@@STEP_LOG_LINE@revisions@r2@@@",
+ "@@@STEP_LOG_LINE@revisions@r3@@@",
+ "@@@STEP_LOG_LINE@revisions@r4@@@",
+ "@@@STEP_LOG_LINE@revisions@r5@@@",
"@@@STEP_LOG_END@revisions@@@"
]
},
{
"cmd": [],
"cwd": "[SLAVE_BUILD]",
- "name": "test r1"
+ "name": "test r2"
},
{
"cmd": [
@@ -219,21 +222,21 @@
"--output_json",
"/path/to/tmp/json",
"--revision",
- "src@r1",
+ "src@r2",
"--output_manifest"
],
"cwd": "[SLAVE_BUILD]",
"env": {
"PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
},
- "name": "test r1.bot_update",
+ "name": "test r2.bot_update",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_TEXT@Some step text@@@",
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"did_run\": true, @@@",
"@@@STEP_LOG_LINE@json.output@ \"fixed_revisions\": {@@@",
- "@@@STEP_LOG_LINE@json.output@ \"src\": \"r1\"@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"src\": \"r2\"@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"manifest\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"src\": {@@@",
@@ -306,7 +309,7 @@
"RECIPE_PACKAGE_REPO[depot_tools]/download_from_google_storage.py"
],
"cwd": "[SLAVE_BUILD]",
- "name": "test r1.ensure_goma",
+ "name": "test r2.ensure_goma",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@"
]
@@ -324,7 +327,7 @@
"GYP_DEFINES": "archive_gpu_tests=1 component=static_library ffmpeg_branding=Chrome gomadir='[SLAVE_BUILD]/src/build/goma/client' proprietary_codecs=1 target_arch=x64 test_isolation_mode=prepare use_goma=1",
"PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
},
- "name": "test r1.gclient runhooks",
+ "name": "test r2.gclient runhooks",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@"
]
@@ -346,7 +349,7 @@
"{\"buildername\": \"linux_variable\", \"buildnumber\": \"1\", \"mastername\": \"tryserver.chromium.linux\", \"slavename\": \"build1-a1\", \"target_platform\": \"linux\"}"
],
"cwd": "[SLAVE_BUILD]",
- "name": "test r1.get compile targets for scripts",
+ "name": "test r2.get compile targets for scripts",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@json.output@{}@@@",
@@ -362,7 +365,7 @@
"/path/to/tmp/json"
],
"cwd": "[SLAVE_BUILD]",
- "name": "test r1.read test spec",
+ "name": "test r2.read test spec",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_TEXT@path: [SLAVE_BUILD]/src/testing/buildbot/chromium.linux.json@@@",
@@ -387,7 +390,7 @@
"//out/Release"
],
"cwd": "[SLAVE_BUILD]",
- "name": "test r1.generate_build_files",
+ "name": "test r2.generate_build_files",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@"
]
@@ -405,7 +408,7 @@
"/path/to/tmp/json"
],
"cwd": "[SLAVE_BUILD]",
- "name": "test r1.check_targets",
+ "name": "test r2.check_targets",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@json.output@{@@@",
@@ -427,7 +430,7 @@
"RECIPE_PACKAGE_REPO[build]/scripts/slave/cleanup_temp.py"
],
"cwd": "[SLAVE_BUILD]",
- "name": "test r1.cleanup_temp",
+ "name": "test r2.cleanup_temp",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@"
]
@@ -449,7 +452,7 @@
"//out/Release"
],
"cwd": "[SLAVE_BUILD]",
- "name": "test r1.generate_build_files (2)",
+ "name": "test r2.generate_build_files (2)",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@"
]
@@ -483,11 +486,15 @@
"target_name"
],
"cwd": "[SLAVE_BUILD]",
- "name": "test r1.compile",
+ "name": "test r2.compile",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@",
+ "step returned non-zero exit code: 1",
"@@@STEP_LOG_LINE@json.output (invalid)@null@@@",
- "@@@STEP_LOG_END@json.output (invalid)@@@"
+ "@@@STEP_LOG_END@json.output (invalid)@@@",
+ "@@@STEP_LOG_LINE@exception@TypeError(\"'NoneType' object has no attribute '__getitem__'\",)@@@",
+ "@@@STEP_LOG_END@exception@@@",
+ "@@@STEP_WARNINGS@@@"
]
},
{
@@ -499,16 +506,26 @@
"cwd": "[SLAVE_BUILD]",
"name": "report",
"~followup_annotations": [
+ "@@@STEP_TEXT@<br/>Culprit: <a href=\"https://crrev.com/r2\">r2</a>@@@",
"@@@STEP_LOG_LINE@report@{@@@",
"@@@STEP_LOG_LINE@report@ \"result\": {@@@",
- "@@@STEP_LOG_LINE@report@ \"r1\": \"passed\"@@@",
+ "@@@STEP_LOG_LINE@report@ \"r2\": \"failed\"@@@",
"@@@STEP_LOG_LINE@report@ }, @@@",
"@@@STEP_LOG_LINE@report@ \"metadata\": {@@@",
- "@@@STEP_LOG_LINE@report@ \"regression_range_size\": 1@@@",
+ "@@@STEP_LOG_LINE@report@ \"regression_range_size\": 4, @@@",
+ "@@@STEP_LOG_LINE@report@ \"sub_ranges\": [@@@",
+ "@@@STEP_LOG_LINE@report@ [@@@",
+ "@@@STEP_LOG_LINE@report@ null, @@@",
+ "@@@STEP_LOG_LINE@report@ \"r2\", @@@",
+ "@@@STEP_LOG_LINE@report@ \"r3\", @@@",
+ "@@@STEP_LOG_LINE@report@ \"r4\", @@@",
+ "@@@STEP_LOG_LINE@report@ \"r5\"@@@",
+ "@@@STEP_LOG_LINE@report@ ]@@@",
+ "@@@STEP_LOG_LINE@report@ ]@@@",
"@@@STEP_LOG_LINE@report@ }@@@",
"@@@STEP_LOG_LINE@report@}@@@",
"@@@STEP_LOG_END@report@@@",
- "@@@SET_BUILD_PROPERTY@report@{\"metadata\": {\"regression_range_size\": 1}, \"result\": {\"r1\": \"passed\"}}@@@"
+ "@@@SET_BUILD_PROPERTY@report@{\"metadata\": {\"regression_range_size\": 4, \"sub_ranges\": [[null, \"r2\", \"r3\", \"r4\", \"r5\"]]}, \"result\": {\"r2\": \"failed\"}}@@@"
]
},
{

Powered by Google App Engine
This is Rietveld 408576698