Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1869203003: Fix memory usage bug. (Closed)

Created:
4 years, 8 months ago by hubbe
Modified:
4 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix memory usage bug. Don't tell multibuffer that it's ok to use 25Mb if we don't need it. Instead, use the bitrate to figure out what the max buffer should be (but clamp it to 25Mb). BUG=595827 Committed: https://crrev.com/c3694d28aca6e32401771f6e9c47bb47a457fd3e Cr-Commit-Position: refs/heads/master@{#385963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/blink/multibuffer_data_source.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
hubbe
4 years, 8 months ago (2016-04-07 23:23:04 UTC) #2
DaleCurtis
lgtm
4 years, 8 months ago (2016-04-07 23:56:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869203003/1
4 years, 8 months ago (2016-04-08 00:10:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 03:07:30 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 03:08:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3694d28aca6e32401771f6e9c47bb47a457fd3e
Cr-Commit-Position: refs/heads/master@{#385963}

Powered by Google App Engine
This is Rietveld 408576698