scripts/slave/recipe_modules/chromium_android/example.expected/device_flags_builder_basic.json - Issue 1869193003: Remove logcats from instrumentation test run steps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_android/example.expected/device_flags_builder_basic.json

Issue 1869193003: Remove logcats from instrumentation test run steps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Rebase! Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/example.expected/coverage_builder_basic.json ('k') | scripts/slave/recipe_modules/chromium_android/example.expected/downgrade_install_tester_basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_android/example.expected/device_flags_builder_basic.json

diff --git a/scripts/slave/recipe_modules/chromium_android/example.expected/device_flags_builder_basic.json b/scripts/slave/recipe_modules/chromium_android/example.expected/device_flags_builder_basic.json

index b4faa480b5210b5a508e0ff17d72bfde1281950c..3c2e13630e06d571e46153b676fb88c925e8443f 100644

--- a/scripts/slave/recipe_modules/chromium_android/example.expected/device_flags_builder_basic.json

+++ b/scripts/slave/recipe_modules/chromium_android/example.expected/device_flags_builder_basic.json

@@ -555,8 +555,6 @@

"instrumentation",

"--blacklist-file",

"[SLAVE_BUILD]/src/out/bad_devices.json",

- "--logcat-output-file",

- "/path/to/tmp/",

"--flakiness-dashboard-server",

"test-results.appspot.com",

"-A",

@@ -583,13 +581,7 @@

"env": {

"CHROMIUM_OUTPUT_DIR": "[SLAVE_BUILD]/src/out/Release"

- "name": "Instrumentation test SmallTest",

- "~followup_annotations": [

- "@@@STEP_LOG_LINE@logcat@logging...@@@",

- "@@@STEP_LOG_LINE@logcat@beep@@@",

- "@@@STEP_LOG_LINE@logcat@boop\bbop@@@",

- "@@@STEP_LOG_END@logcat@@@"

- ]

+ "name": "Instrumentation test SmallTest"

{

"cmd": [