Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 1869193003: Remove logcats from instrumentation test run steps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Rebase! Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_android/example.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index 54dc4bd2856e972f52703f111b7fc5f69cc9d3e0..5f3f6928235109a91373873b41e3f411613aba91 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -679,10 +679,8 @@ class AndroidApi(recipe_api.RecipeApi):
device_flags=None,
wrapper_script_suite_name=None,
**kwargs):
- logcat_output_file = self.m.raw_io.output()
args = [
'--blacklist-file', self.blacklist_file,
- '--logcat-output-file', logcat_output_file,
]
if tool:
args.append('--tool=%s' % tool)
@@ -732,9 +730,6 @@ class AndroidApi(recipe_api.RecipeApi):
args=args,
wrapper_script_suite_name=wrapper_script_suite_name,
**kwargs)
- if step_result.raw_io.output:
- step_result.presentation.logs['logcat'] = (
- step_result.raw_io.output.splitlines())
return step_result
def launch_gce_instances(self, snapshot='clean-17-l-phone-image-no-popups',
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_android/example.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698