Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1869143003: Revert of Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS (Closed)

Created:
4 years, 8 months ago by miu
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS (patchset #1 id:1 of https://codereview.chromium.org/1859363005/ ) Reason for revert: Fixed by: https://codereview.chromium.org/1871663002/ Original issue's description: > Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS > > BUG=601306 > TBR=rkc > NOTRY=true > > Committed: https://crrev.com/eac516a0acc5863cb988937194d645928cc4871a > Cr-Commit-Position: refs/heads/master@{#385748} TBR=rkc@chromium.org,beaudoin@chromium.org,magjed@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601306 Committed: https://crrev.com/c9b2f15deeed56d7f1765a170eeb8c663cf481f0 Cr-Commit-Position: refs/heads/master@{#385889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
miu
Created Revert of Disable flaky FeedbackTest.ShowLoginFeedback on Chrome OS
4 years, 8 months ago (2016-04-07 21:55:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869143003/1
4 years, 8 months ago (2016-04-07 21:56:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 21:56:51 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 21:58:57 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9b2f15deeed56d7f1765a170eeb8c663cf481f0
Cr-Commit-Position: refs/heads/master@{#385889}

Powered by Google App Engine
This is Rietveld 408576698