Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4180)

Unified Diff: build/android/pylib/utils/proguard.py

Issue 1869083002: 🎽 Fix instrumentation test proguard parser when gmscore has annotations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/utils/proguard.py
diff --git a/build/android/pylib/utils/proguard.py b/build/android/pylib/utils/proguard.py
index 244978e24f8b79493bd83c7d0121cd76159ff393..89dc4c79b331760d0add4628ca50187aaf8d9bf7 100644
--- a/build/android/pylib/utils/proguard.py
+++ b/build/android/pylib/utils/proguard.py
@@ -284,5 +284,8 @@ def Parse(proguard_output):
if m:
state.UpdateCurrentAnnotationFieldValue(
m.group(2), _GetDepth(m.group(1)))
+ else:
+ state.InitMethod(None)
jbudorick 2016/04/08 00:59:09 What does this line that gets here contain? It's n
dgn 2016/04/08 16:54:52 So that clears the annotation stack when we hit so
agrieve 2016/04/08 17:35:36 That's what we want, but it's not what the code wa
+
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698