Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1869063004: components: Add out-of-line copy ctors for complex classes. (Closed)

Created:
4 years, 8 months ago by vmpstr
Modified:
4 years, 8 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

components: Add out-of-line copy ctors for complex classes. This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=jochen@chromium.org, dcheng@chromium.org, thakis@chromium.org Committed: https://crrev.com/6451101038c686b51cd6e6e7251c7e627102f17e Cr-Commit-Position: refs/heads/master@{#386173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M components/drive/file_change.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/drive/file_change.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/leak_detector/leak_detector.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/leak_detector/leak_detector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/metrics/leak_detector/leak_detector_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/leak_detector/leak_detector_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/wifi/network_properties.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/wifi/network_properties.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/wifi_sync/wifi_credential.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/wifi_sync/wifi_credential.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vmpstr
Please take a look.
4 years, 8 months ago (2016-04-07 22:26:35 UTC) #1
dcheng
rs lgtm
4 years, 8 months ago (2016-04-07 22:30:26 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-08 02:18:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869063004/1
4 years, 8 months ago (2016-04-08 18:04:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 19:59:46 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 20:01:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6451101038c686b51cd6e6e7251c7e627102f17e
Cr-Commit-Position: refs/heads/master@{#386173}

Powered by Google App Engine
This is Rietveld 408576698