Arc integration in shelf launcher context menu.

Arc integration in shelf launcher context menu.

This is the second split of orignal cl: https://codereview.chromium.org/1838263002/
First split is: https://codereview.chromium.org/1857213004
BUG= http://b/27418199
TEST= Manual test on minnie after setting Arc to multi-window mode. Unit test covers menu item checks after the creation of DesktopShellLauncherContextMenu and ArcLauncherContextMenu.

Committed: https://crrev.com/fb71d484f7ddb5a857cc3c31f48be0b8c5762b90
Cr-Commit-Position: refs/heads/master@{#385853}

[lgcheng, 2016-04-07 17:30:37]

lgcheng@google.com changed reviewers:
+ stevenjb@chromium.org

[lgcheng, 2016-04-07 17:30:37]

Hi Steven,

PTAL at this patch which covers Arc integration in shelf launcher context menu.

This is the second split of https://codereview.chromium.org/1838263002/

[lgcheng, 2016-04-07 17:30:43]

The CQ bit was checked by lgcheng@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 17:31:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869063002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869063002/1

[lgcheng, 2016-04-07 17:34:17]

Description was changed from

==========
Arc integration in shelf launcher context menu.
Arc integration in shelf launcher context menu.

This is the second split of orignal cl:
https://codereview.chromium.org/1838263002/
First split is: https://codereview.chromium.org/1857213004
BUG= http://b/27418199
TEST= Manual test on minnie after setting Arc to multi-window mode. Unit test
covers menu item checks after the creation of DesktopShellLauncherContextMenu
and ArcLauncherContextMenu.
==========

to

==========
Arc integration in shelf launcher context menu.

This is the second split of orignal cl:
https://codereview.chromium.org/1838263002/
First split is: https://codereview.chromium.org/1857213004
BUG= http://b/27418199
TEST= Manual test on minnie after setting Arc to multi-window mode. Unit test
covers menu item checks after the creation of DesktopShellLauncherContextMenu
and ArcLauncherContextMenu.
==========

[commit-bot: I haz the power, 2016-04-07 18:13:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 18:13:32]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-04-07 18:58:12]

https://codereview.chromium.org/1869063002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/launcher_context_menu.cc (right):

https://codereview.chromium.org/1869063002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/launcher_context_menu.cc:17: #include
"chrome/browser/ui/ash/launcher/arc_launcher_context_menu.h"
If we are only using this on Chrome OS then we should only include it for cros.

https://codereview.chromium.org/1869063002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc (right):

https://codereview.chromium.org/1869063002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc:16: #include
"chrome/browser/ui/ash/launcher/arc_launcher_context_menu.h"
cros only?

[lgcheng, 2016-04-07 19:40:51]

Thanks for comment!

PTAL at the update.

Thanks

https://codereview.chromium.org/1869063002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/launcher_context_menu.cc (right):

https://codereview.chromium.org/1869063002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/launcher_context_menu.cc:17: #include
"chrome/browser/ui/ash/launcher/arc_launcher_context_menu.h"
On 2016/04/07 18:58:12, stevenjb wrote:
> If we are only using this on Chrome OS then we should only include it for
cros.

Done.

https://codereview.chromium.org/1869063002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc (right):

https://codereview.chromium.org/1869063002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc:16: #include
"chrome/browser/ui/ash/launcher/arc_launcher_context_menu.h"
On 2016/04/07 18:58:12, stevenjb wrote:
> cros only?

Done.

[stevenjb, 2016-04-07 19:42:18]

lgtm

[lgcheng, 2016-04-07 19:43:04]

The CQ bit was checked by lgcheng@google.com

[commit-bot: I haz the power, 2016-04-07 19:43:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869063002/20001

[commit-bot: I haz the power, 2016-04-07 21:14:27]

Description was changed from

==========
Arc integration in shelf launcher context menu.

This is the second split of orignal cl:
https://codereview.chromium.org/1838263002/
First split is: https://codereview.chromium.org/1857213004
BUG= http://b/27418199
TEST= Manual test on minnie after setting Arc to multi-window mode. Unit test
covers menu item checks after the creation of DesktopShellLauncherContextMenu
and ArcLauncherContextMenu.
==========

to

==========
Arc integration in shelf launcher context menu.

This is the second split of orignal cl:
https://codereview.chromium.org/1838263002/
First split is: https://codereview.chromium.org/1857213004
BUG= http://b/27418199
TEST= Manual test on minnie after setting Arc to multi-window mode. Unit test
covers menu item checks after the creation of DesktopShellLauncherContextMenu
and ArcLauncherContextMenu.
==========

[commit-bot: I haz the power, 2016-04-07 21:14:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-07 21:29:28]

Description was changed from

==========
Arc integration in shelf launcher context menu.

This is the second split of orignal cl:
https://codereview.chromium.org/1838263002/
First split is: https://codereview.chromium.org/1857213004
BUG= http://b/27418199
TEST= Manual test on minnie after setting Arc to multi-window mode. Unit test
covers menu item checks after the creation of DesktopShellLauncherContextMenu
and ArcLauncherContextMenu.
==========

to

==========
Arc integration in shelf launcher context menu.

This is the second split of orignal cl:
https://codereview.chromium.org/1838263002/
First split is: https://codereview.chromium.org/1857213004
BUG= http://b/27418199
TEST= Manual test on minnie after setting Arc to multi-window mode. Unit test
covers menu item checks after the creation of DesktopShellLauncherContextMenu
and ArcLauncherContextMenu.

Committed: https://crrev.com/fb71d484f7ddb5a857cc3c31f48be0b8c5762b90
Cr-Commit-Position: refs/heads/master@{#385853}
==========

[commit-bot: I haz the power, 2016-04-07 21:29:29]

Patchset 2 (id:??) landed as
https://crrev.com/fb71d484f7ddb5a857cc3c31f48be0b8c5762b90
Cr-Commit-Position: refs/heads/master@{#385853}