Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1356)

Unified Diff: scripts/master/chromium_step.py

Issue 1869053002: kitchen_run: initial CL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/master/chromium_step.py
diff --git a/scripts/master/chromium_step.py b/scripts/master/chromium_step.py
index 7f449ee63427280a8c12113a1b649ed7913c9c12..3adc45fd700ac813a3249f195593e5b55e847f82 100644
--- a/scripts/master/chromium_step.py
+++ b/scripts/master/chromium_step.py
@@ -1058,8 +1058,15 @@ class AnnotationObserver(buildstep.LogLineObserver):
# Support: @@@SET_BUILD_PROPERTY@<name>@<json>@@@
# Sets the property and indicates that it came from an annoation on the
# current step.
- self.command.build.setProperty(name, json.loads(value), 'Annotation(%s)'
- % self.cursor['name'])
+ try:
+ self.command.build.setProperty(name, json.loads(value), 'Annotation(%s)'
+ % self.cursor['name'])
+ except Exception as e:
+ raise Exception(repr([
estaab 2016/04/08 05:22:46 What's the format of the regular exception? If you
dnj 2016/04/11 18:17:15 Why is this here in the first place? Is this debug
Paweł Hajdan Jr. 2016/04/11 20:44:39 "As you see, it has some local hacks I've used for
+ str(e),
+ str(name),
+ str(value),
+ ]))
def STEP_LOG_LINE(self, log_label, log_line):
# Support: @@@STEP_LOG_LINE@<label>@<line>@@@ (add log to step)

Powered by Google App Engine
This is Rietveld 408576698