kitchen_run: initial CL

scripts/master/chromium_step.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Subclasses of various slave command classes."""
 
 from datetime import datetime
 import copy
 import errno
 import json
@@ skipping 1040 matching lines @@
 
   def finalizeLogLines(self, section, log_label):
     section['finished_logs'].append(log_label)
     logs = section['annotated_logs'].pop(log_label, ())
     addLogToStep(section['step'], log_label, '\n'.join(logs))
 
   def SET_BUILD_PROPERTY(self, name, value):
     # Support: @@@SET_BUILD_PROPERTY@<name>@<json>@@@
     # Sets the property and indicates that it came from an annoation on the
     # current step.
-    self.command.build.setProperty(name, json.loads(value), 'Annotation(%s)'
-                                   % self.cursor['name'])
+    try:
+      self.command.build.setProperty(name, json.loads(value), 'Annotation(%s)'
+                                     % self.cursor['name'])
+    except Exception as e:
+      raise Exception(repr([

[estaab, 2016/04/08 05:22:46]

What's the format of the regular exception? If you need to override it can you
format it so it's clear what the exception, name, and value each are?

[dnj, 2016/04/11 18:17:15]

Why is this here in the first place? Is this debugging?

[Paweł Hajdan Jr., 2016/04/11 20:44:39]

"As you see, it has some local hacks I've used for testing. They'll be removed
before final review and landing."

+        str(e),
+        str(name),
+        str(value),
+      ]))
 
   def STEP_LOG_LINE(self, log_label, log_line):
     # Support: @@@STEP_LOG_LINE@<label>@<line>@@@ (add log to step)
     # Appends a line to the log's array. When STEP_LOG_END is called,
     # that will finalize the log and call addCompleteLog().
     self.addLogLines(log_label, (log_line,))
 
   def STEP_LOG_END(self, log_label):
     # Support: @@@STEP_LOG_END@<label>@@@ (finalizes log to step)
     if (len(self.cursor['finished_logs'])+1) >= self._STEP_MAX_LOGS:
@@ skipping 470 matching lines @@
       and starts to wait for remaining steps to finish. Returns command_result
       as Deferred."""
       self.scriptComplete(command_result)
       steps_d = self.script_observer.waitForSteps()
       # Ignore the waitForSteps' result and return the original result,
       # so the caller of runCommand receives command_result.
       steps_d.addCallback(lambda *_: command_result)
       return steps_d
     d.addCallback(onCommandFinished)
     return d