Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1869033002: S390: Bugfix: assert in lithium compile for LMaybeGrowElements (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Bugfix: assert in lithium compile for LMaybeGrowElements Port ce1fe78d7e7d8b45d56bcab4cea1d3eab6dcfc79 R=mvstanton@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG=chromium:585041 LOG=N Committed: https://crrev.com/224210a5946548a05530eda7b6cb5e362fb4f8fb Cr-Commit-Position: refs/heads/master@{#35340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-07 14:27:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869033002/1
4 years, 8 months ago (2016-04-07 14:27:34 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-07 14:47:01 UTC) #5
MTBrandyberry
lgtm
4 years, 8 months ago (2016-04-07 15:01:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869033002/1
4 years, 8 months ago (2016-04-07 16:18:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 16:21:44 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 16:23:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/224210a5946548a05530eda7b6cb5e362fb4f8fb
Cr-Commit-Position: refs/heads/master@{#35340}

Powered by Google App Engine
This is Rietveld 408576698