Fixing AudioBuffer params and channel layout bugs

media/renderers/audio_renderer_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/renderers/audio_renderer_impl.h"
 
 #include <math.h>
 #include <stddef.h>
 #include <algorithm>
 #include <utility>
@@ skipping 517 matching lines @@
 
     DCHECK(buffer_converter_);
     buffer_converter_->AddInput(buffer);
     while (buffer_converter_->HasNextBuffer()) {
       if (!splicer_->AddInput(buffer_converter_->GetNextBuffer())) {
         HandleAbortedReadOrDecodeError(AUDIO_RENDERER_ERROR_SPLICE_FAILED);
         return;
       }
     }
   } else {
+    // Check if the buffer we received matches the expected configuration.

[DaleCurtis, 2016/04/07 20:05:04]

Add something like:

// TODO(chcunningham, tguilbert): Figure out if we want to support implicit
// config changes during src=. Doing so requires resampling each individual
// stream which is inefficient when there are many tags in a page.
//
// Note: We explicitly do not check channel layout here to avoid breaking
// weird behavior with multichannel wave files: http://crbug.com/600538.

[tguilbert, 2016/04/07 21:08:50]

Done.

+

[DaleCurtis, 2016/04/07 20:05:04]

No extra line.

[tguilbert, 2016/04/07 21:08:50]

Done.

+    if (!buffer->end_of_stream() &&
+        (buffer->sample_rate() != audio_parameters_.sample_rate() ||
+         buffer->channel_count() !=
+             ChannelLayoutToChannelCount(audio_parameters_.channel_layout()))) {

[DaleCurtis, 2016/04/07 20:05:04]

Just use audio_parameters_.channels() ?

[tguilbert, 2016/04/07 21:08:50]

Oops! You are right. Done.

+      HandleAbortedReadOrDecodeError(PIPELINE_ERROR_DECODE);

[DaleCurtis, 2016/04/07 20:05:04]

Add a MEDIA_LOG in here, something like:

MEDIA_LOG(ERROR, media_log_)
    << "Unsupported midstream configuration change!"
    << " Sample Rate: " << buffer->sample_rate() << " vs "
    << audio_parameters_.sample_rate()
    << ", Channels: " << buffer->channel_count() << " vs "
    << audio_parameters_.channels();

[tguilbert, 2016/04/07 21:08:50]

Done.

+    }
+
     if (!splicer_->AddInput(buffer)) {
       HandleAbortedReadOrDecodeError(AUDIO_RENDERER_ERROR_SPLICE_FAILED);
       return;
     }
   }
 
   if (!splicer_->HasNextBuffer()) {
     AttemptRead_Locked();
     return;
   }
@@ skipping 333 matching lines @@
            << buffering_state;
   DCHECK_NE(buffering_state_, buffering_state);
   lock_.AssertAcquired();
   buffering_state_ = buffering_state;
 
   task_runner_->PostTask(FROM_HERE,
                          base::Bind(buffering_state_cb_, buffering_state_));
 }
 
 }  // namespace media