Fixing AudioBuffer params and channel layout bugs

media/filters/ffmpeg_audio_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/ffmpeg_audio_decoder.h"
 
 #include <stdint.h>
 
 #include "base/callback_helpers.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 282 matching lines @@
     packet.data += result;
 
     scoped_refptr<AudioBuffer> output;
 
     bool config_changed = false;
     if (frame_decoded) {
       const int channels = DetermineChannels(av_frame_.get());
       ChannelLayout channel_layout = ChannelLayoutToChromeChannelLayout(
           codec_context_->channel_layout, codec_context_->channels);
 
-      if (av_frame_->sample_rate != config_.samples_per_second() ||
-          channel_layout != config_.channel_layout() ||
+      bool config_is_stale =

[DaleCurtis, 2016/04/07 20:05:04]

Naming style in chrome is typically "is_config_stale"

[tguilbert, 2016/04/07 21:08:50]

Done.

+          av_frame_->sample_rate != config_.samples_per_second() ||
           channels != ChannelLayoutToChannelCount(config_.channel_layout()) ||
-          av_frame_->format != av_sample_format_) {
+          av_frame_->format != av_sample_format_;
+
+      // Only consider channel layout changes for AAC.

[DaleCurtis, 2016/04/07 20:05:04]

Add a comment why, something like:

// TODO(tguilbert, dalecurtis): Due to http://crbug.com/600538 we need to
// allow channel layout changes for the time being. See if ffmpeg is fixable.

[tguilbert, 2016/04/07 21:08:50]

Done.

+      if(config_.codec() == kCodecAAC){

[DaleCurtis, 2016/04/07 20:05:04]

run git cl format to fix formatting errors. notably spaces around () and no need
for {}

[tguilbert, 2016/04/07 21:08:50]

Done.

+        config_is_stale |= channel_layout != config_.channel_layout();
+      }
+
+      if (config_is_stale) {
         // Only allow midstream configuration changes for AAC. Sample format is
         // not expected to change between AAC profiles.
         if (config_.codec() == kCodecAAC &&
             av_frame_->format == av_sample_format_) {
           MEDIA_LOG(DEBUG, media_log_)
               << " Detected AAC midstream configuration change"
               << " PTS:" << buffer->timestamp().InMicroseconds()
               << " Sample Rate: " << av_frame_->sample_rate << " vs "
               << config_.samples_per_second()
               << ", ChannelLayout: " << channel_layout << " vs "
               << config_.channel_layout() << ", Channels: " << channels
               << " vs "
               << ChannelLayoutToChannelCount(config_.channel_layout());
           config_.Initialize(config_.codec(), config_.sample_format(),
                              channel_layout, av_frame_->sample_rate,
                              config_.extra_data(), config_.encryption_scheme(),
                              config_.seek_preroll(), config_.codec_delay());
           config_changed = true;
           ResetTimestampState();

[DaleCurtis, 2016/04/07 20:05:04]

This only needs to be called when sample_rate changes.

[tguilbert, 2016/04/07 21:08:50]

Does this need to be called before discard_helper_->ProcessBuffers(_,_) on line
365?

         } else {
           MEDIA_LOG(ERROR, media_log_)
               << "Unsupported midstream configuration change!"
               << " Sample Rate: " << av_frame_->sample_rate << " vs "
               << config_.samples_per_second() << ", Channels: " << channels
               << " vs " << ChannelLayoutToChannelCount(config_.channel_layout())
               << ", Sample Format: " << av_frame_->format << " vs "
               << av_sample_format_;
           // This is an unrecoverable error, so bail out.
           av_frame_unref(av_frame_.get());
@@ skipping 84 matching lines @@
   return true;
 }
 
 void FFmpegAudioDecoder::ResetTimestampState() {
   discard_helper_.reset(new AudioDiscardHelper(config_.samples_per_second(),
                                                config_.codec_delay()));
   discard_helper_->Reset(config_.codec_delay());
 }
 
 }  // namespace media