Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1868973002: Fix representation issue in FastArrayPushStub (Closed)

Created:
4 years, 8 months ago by Camillo Bruni
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix representation issue in FastArrayPushStub Pushing undefined onto a FAST_DOUBLE_ARRAY does not enforce the right representation checks. BUG=chromium:599089 LOG=n Committed: https://crrev.com/9478356ed307dbb4a51005fa250516bd567fe10b Cr-Commit-Position: refs/heads/master@{#35332}

Patch Set 1 #

Patch Set 2 : moa #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +9 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-599089-array-push.js View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Camillo Bruni
PTAL
4 years, 8 months ago (2016-04-07 12:03:05 UTC) #3
Toon Verwaest
lgtm
4 years, 8 months ago (2016-04-07 12:05:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868973002/20001
4 years, 8 months ago (2016-04-07 12:21:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 12:44:15 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 12:46:19 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9478356ed307dbb4a51005fa250516bd567fe10b
Cr-Commit-Position: refs/heads/master@{#35332}

Powered by Google App Engine
This is Rietveld 408576698