runtime/vm/regexp_assembler_ir.cc - Issue 1868803002: Use symbols when looking up fields in a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/regexp_assembler_ir.cc

Issue 1868803002: Use symbols when looking up fields in a class (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/regexp_assembler_ir.cc

diff --git a/runtime/vm/regexp_assembler_ir.cc b/runtime/vm/regexp_assembler_ir.cc

index 6f656dbb9e86573ecc157815f5d92ba451ef7645..aac090e27d315d93808808cedc53a3a66fcdc437 100644

--- a/runtime/vm/regexp_assembler_ir.cc

+++ b/runtime/vm/regexp_assembler_ir.cc

@@ -431,7 +431,7 @@ ConstantInstr* IRRegExpMacroAssembler::WordCharacterMapConstant() const {

const Class& regexp_class = Class::Handle(Z,

lib.LookupClassAllowPrivate(Symbols::_RegExp()));

const Field& word_character_field = Field::ZoneHandle(Z,

- regexp_class.LookupStaticField(Symbols::_wordCharacterMap()));

+ regexp_class.LookupStaticFieldAllowPrivate(Symbols::_wordCharacterMap()));

ASSERT(!word_character_field.IsNull());

if (word_character_field.IsUninitialized()) {

« runtime/vm/object.cc ('K') | « runtime/vm/parser_test.cc ('k') | no next file » | no next file with comments »