runtime/vm/parser.cc - Issue 1868803002: Use symbols when looking up fields in a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 1868803002: Use symbols when looking up fields in a class (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/parser.cc

diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc

index 569152283b4f545cf0ce62443619786f17f82723..3581662c14f696f979b44ba1988a2f582f1766d9 100644

--- a/runtime/vm/parser.cc

+++ b/runtime/vm/parser.cc

@@ -4794,7 +4794,7 @@ void Parser::ParseEnumDefinition(const Class& cls) {

// Create a static field that contains the list of enumeration names.

// Clone the _enum_names field from the helper class.

Field& names_field = Field::Handle(Z,

- helper_class.LookupStaticField(Symbols::_EnumNames()));

+ helper_class.LookupStaticFieldAllowPrivate(Symbols::_EnumNames()));

ASSERT(!names_field.IsNull());

names_field = names_field.Clone(cls);

enum_members.AddField(names_field);