Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: runtime/vm/debugger.cc

Issue 1868803002: Use symbols when looking up fields in a class (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/debugger.h" 5 #include "vm/debugger.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 8
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 2346 matching lines...) Expand 10 before | Expand all | Expand 10 after
2357 } else { 2357 } else {
2358 result = Thread::Current()->sticky_error(); 2358 result = Thread::Current()->sticky_error();
2359 } 2359 }
2360 ignore_breakpoints_ = saved_ignore_flag; 2360 ignore_breakpoints_ = saved_ignore_flag;
2361 return result.raw(); 2361 return result.raw();
2362 } 2362 }
2363 2363
2364 2364
2365 RawObject* Debugger::GetStaticField(const Class& cls, 2365 RawObject* Debugger::GetStaticField(const Class& cls,
2366 const String& field_name) { 2366 const String& field_name) {
2367 const Field& fld = Field::Handle(cls.LookupStaticField(field_name)); 2367 const Field& fld =
2368 Field::Handle(cls.LookupStaticFieldAllowPrivate(field_name));
2368 if (!fld.IsNull()) { 2369 if (!fld.IsNull()) {
2369 // Return the value in the field if it has been initialized already. 2370 // Return the value in the field if it has been initialized already.
2370 const Instance& value = Instance::Handle(fld.StaticValue()); 2371 const Instance& value = Instance::Handle(fld.StaticValue());
2371 ASSERT(value.raw() != Object::transition_sentinel().raw()); 2372 ASSERT(value.raw() != Object::transition_sentinel().raw());
2372 if (value.raw() != Object::sentinel().raw()) { 2373 if (value.raw() != Object::sentinel().raw()) {
2373 return value.raw(); 2374 return value.raw();
2374 } 2375 }
2375 } 2376 }
2376 // There is no field or the field has not been initialized yet. 2377 // There is no field or the field has not been initialized yet.
2377 // We must have a getter. Run the getter. 2378 // We must have a getter. Run the getter.
(...skipping 968 matching lines...) Expand 10 before | Expand all | Expand 10 after
3346 3347
3347 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) { 3348 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) {
3348 ASSERT(bpt->next() == NULL); 3349 ASSERT(bpt->next() == NULL);
3349 bpt->set_next(code_breakpoints_); 3350 bpt->set_next(code_breakpoints_);
3350 code_breakpoints_ = bpt; 3351 code_breakpoints_ = bpt;
3351 } 3352 }
3352 3353
3353 #endif // !PRODUCT 3354 #endif // !PRODUCT
3354 3355
3355 } // namespace dart 3356 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/exceptions.cc » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698