Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 18688002: Set 5M memory for OutOfMemory and OutOfMemoryNested test cases. (Closed)

Created:
7 years, 5 months ago by kilvadyb
Modified:
7 years, 5 months ago
Reviewers:
kisg, Paul Lind, palfia, danno, Yang
CC:
v8-dev
Visibility:
Public.

Description

Set 5M memory for OutOfMemory and OutOfMemoryNested test cases. BUG= TEST=cctest/test-api/OutOfMemory cctest/test-api/OutOfMemoryNested

Patch Set 1 #

Patch Set 2 : Size increases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/cctest/test-api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kilvadyb
On Linux and Mac machines running MIPS simulator tests, we need 4K (Page::kPageSize) more memory ...
7 years, 5 months ago (2013-07-04 11:17:57 UTC) #1
Yang
On 2013/07/04 11:17:57, kilvadyb wrote: > On Linux and Mac machines running MIPS simulator tests, ...
7 years, 5 months ago (2013-07-04 15:07:08 UTC) #2
kilvadyb
Sizes set to 5 * K * K.
7 years, 5 months ago (2013-07-04 15:43:07 UTC) #3
Yang
On 2013/07/04 15:43:07, kilvadyb wrote: > Sizes set to 5 * K * K. LGTM.
7 years, 5 months ago (2013-07-04 16:06:32 UTC) #4
kilvadyb
7 years, 5 months ago (2013-07-04 16:59:59 UTC) #5
palfia
7 years, 5 months ago (2013-07-04 18:45:21 UTC) #6
Committed as r15494.

Powered by Google App Engine
This is Rietveld 408576698